Bugzilla – Attachment 180877 Details for
Bug 38685
ILL pages have incomplete breadcrumbs
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38685: Add missing ops to breadcrumbs
Bug-38685-Add-missing-ops-to-breadcrumbs.patch (text/plain), 3.71 KB, created by
Pedro Amorim
on 2025-04-11 14:34:02 UTC
(
hide
)
Description:
Bug 38685: Add missing ops to breadcrumbs
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-04-11 14:34:02 UTC
Size:
3.71 KB
patch
obsolete
>From f31e0ec6ce0402025379f3811b3f4cf20a656980 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Thu, 12 Dec 2024 13:12:03 +0000 >Subject: [PATCH] Bug 38685: Add missing ops to breadcrumbs > >Breadcrumbs added to the following op pages: >- confirm >- delete_confirm >- generic_confirm >- edititem >- edit_action >- check_out >- cud-cancel >- availability > >Test plan: >1) Enable ILLModule >2) Create a new ILL request: > <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard >3) Try various actions like 'Edit request', 'Confirm request', 'Place > request with partners', etc. >4) Notice the breadcrumbs were previously missing. They are now there. >5) If you want to test the breadcrumbs on the batches pages or > availability check stage let me know and I'll help setting up the > required plugins to have them work. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../prog/en/modules/ill/ill-requests.tt | 28 ++++++++++++++++--- > 1 file changed, 24 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >index 495a3ab9eab..f2e3aa221da 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >@@ -25,11 +25,15 @@ > > [% WRAPPER 'sub-header.inc' %] > [% WRAPPER breadcrumbs %] >- [% WRAPPER breadcrumb_item bc_active = (op == 'illlist' ? 1 : 0) %] >- [% IF op == 'illlist' %] >- <span>ILL requests</span> >+ [% WRAPPER breadcrumb_item bc_active = (op == 'illlist' || op == 'batch_list' ? 1 : 0) %] >+ [% IF op == 'batch_list' %] >+ <a href="/cgi-bin/koha/ill/ill-requests.pl">ILL batch requests</a> > [% ELSE %] >- <a href="/cgi-bin/koha/ill/ill-requests.pl">ILL requests</a> >+ [% IF op == 'illlist' %] >+ <span>ILL requests</span> >+ [% ELSE %] >+ <a href="/cgi-bin/koha/ill/ill-requests.pl">ILL requests</a> >+ [% END %] > [% END %] > [% END %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >@@ -37,6 +41,22 @@ > <span>New request</span> > [% ELSIF op == 'illview' %] > <span>Manage request [% request.id_prefix _ request.illrequest_id | html %]</span> >+ [% ELSIF op == 'confirm' %] >+ <span>Confirm request [% request.id_prefix _ request.illrequest_id | html %]</span> >+ [% ELSIF op == 'delete_confirm' %] >+ <span>Delete request [% request.id_prefix _ request.illrequest_id | html %]</span> >+ [% ELSIF op == 'generic_confirm' %] >+ <span>Place request [% request.id_prefix _ request.illrequest_id | html %] with partners</span> >+ [% ELSIF op == 'edititem' %] >+ <span>Edit item metadata for request [% request.id_prefix _ request.illrequest_id | html %]</span> >+ [% ELSIF op == 'edit_action' %] >+ <span>Edit request [% request.id_prefix _ request.illrequest_id | html %]</span> >+ [% ELSIF op == 'check_out' %] >+ <span>Check out request [% request.id_prefix _ request.illrequest_id | html %]</span> >+ [% ELSIF op == 'cud-cancel' %] >+ <span>Cancel request [% request.id_prefix _ request.illrequest_id | html %]</span> >+ [% ELSIF op == 'availability' %] >+ <span>Availability check</span> > [% ELSIF op == 'typedisclaimer' %] > <span>Request type disclaimer</span> > [% ELSIF op == 'confirmautoill' %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38685
:
175397
|
175399
|
175400
|
175401
|
175460
|
175461
|
175462
|
175463
|
176273
|
176274
|
176275
|
176276
|
179787
|
179788
|
179789
|
179790
|
180874
|
180875
|
180876
| 180877