Bugzilla – Attachment 18093 Details for
Bug 10054
When SingleBranchMode is enabled, allow superlibrarians to set logged in library
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 10054 - When SingleBranchMode is enabled, allow superlibrarians to set logged in library
PASSED-QA-Bug-10054---When-SingleBranchMode-is-ena.patch (text/plain), 2.29 KB, created by
Katrin Fischer
on 2013-05-12 10:30:55 UTC
(
hide
)
Description:
[PASSED QA] Bug 10054 - When SingleBranchMode is enabled, allow superlibrarians to set logged in library
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-05-12 10:30:55 UTC
Size:
2.29 KB
patch
obsolete
>From 2dddd05427b6c58ee5cd1efd89b0050686452325 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 15 Apr 2013 09:09:05 -0400 >Subject: [PATCH] [PASSED QA] Bug 10054 - When SingleBranchMode is enabled, > allow superlibrarians to set logged in library > >Currently, when SingleBranchMode is enabled, nobody can change the >logged in library in Koha. To change it requires disable >SingleBranchMode, switching the library, and re-enabling it. It seems >reasonable to allow superlibrarians to switch the logged in library even >if SingleBranchMode is enabled. > >Test Plan: >1) Apply this patch >3) Enable SingleBranchMode >4) Log in as a superlibrarian >5) Attempt to change the logged in branch > This change should succeed >6) Log in as a non-superlibrarian account >7) Attempt to change the logged n branch > This should not be allowed, as per Koha's current behavior > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >I guess this doesn't do any harm even though the practical motivations >behind it, as described in the bug, seem otherwise solvable. If >SingleBranchMode is supposed to prevent librarians from switching their >logged in library why can they choose their library when they first log >in? Was SingleBranchMode supposed to only affect the OPAC originally? Or >should the login form be modified? This seems to be a band-aid on a >poorly-implemented feature. > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Patch works as decribed. As this only adds a check for a superlibrarian >it seems safe and should not interfere with normal staff accounts. >--- > .../prog/en/modules/circ/selectbranchprinter.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/selectbranchprinter.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/selectbranchprinter.tt >index acad21c..78ebd53 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/selectbranchprinter.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/selectbranchprinter.tt >@@ -49,7 +49,7 @@ Updated:<ul> > <fieldset class="rows"> > <legend>Set library</legend> > <ol> >- [% IF ( singleBranchMode ) %] >+ [% IF ( singleBranchMode && !CAN_user_superlibrarian ) %] > <li>SingleBranchMode is ON.</li> > [% ELSE %] > <li><label for="branch">Choose library:</label> >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10054
:
17453
|
18049
| 18093