Bugzilla – Attachment 180955 Details for
Bug 39446
OPAC ILL request status_alias is not displayed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39446: Show both status and status_alias
Bug-39446-Show-both-status-and-statusalias.patch (text/plain), 3.55 KB, created by
Pedro Amorim
on 2025-04-15 09:41:29 UTC
(
hide
)
Description:
Bug 39446: Show both status and status_alias
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-04-15 09:41:29 UTC
Size:
3.55 KB
patch
obsolete
>From 945f82efc654a099364db32cd7978d9aa5fa45f9 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Tue, 15 Apr 2025 09:38:20 +0000 >Subject: [PATCH] Bug 39446: Show both status and status_alias > >If a request has a status_alias and that status_alias does not have a lib_opac defined, it'll show as an empty status on the OPAC. >Staff UI always shows the request's status and adds the status_alias only if that is defined. The same should happen on the OPAC. > >To test: >1) Enabled ILLModule >2) Create a new ILL request, visit: >http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard >3) Add '42' on the cardnumber. Pick any library. Click 'Create'. >4) Add a new 'status_alias' entry, visit the authorized values page: >http://localhost:8081/cgi-bin/koha/admin/authorised_values.pl >5) Search for 'ill_'. Pick 'ILL_STATUS_ALIAS'. Click 'Add a new authorized value'. >6) Enter the 'Authorized value' of 'test', and 'Description' of 'test'. Click 'Save'. >7) Visit the previously created ILL request: >http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?op=illview&illrequest_id=1 >8) Click 'Edit request' from the top toolbar. >9) On the 'Status' dropdown, pick 'test'. Click 'Submit'. >10) Visit the ILL on the OPAC: >http://localhost:8080/cgi-bin/koha/opac-illrequests.pl >11) Notice the 'status' column does not display the status_alias. Click the 'View', notice the 'status' entry does not display the status_alias. >12) Apply patch. Repeat. Notice it defaults to displaying the authorised value code if lib_opac is empty. >--- > Koha/ILL/Request.pm | 2 +- > .../opac-tmpl/bootstrap/en/modules/opac-illrequests.tt | 7 ++++++- > 2 files changed, 7 insertions(+), 2 deletions(-) > >diff --git a/Koha/ILL/Request.pm b/Koha/ILL/Request.pm >index 39cf0299086..5b5cd14c326 100644 >--- a/Koha/ILL/Request.pm >+++ b/Koha/ILL/Request.pm >@@ -2099,7 +2099,7 @@ This method returns the list of publicly readable database fields for both API a > sub public_read_list { > return [ > qw( >- illrequest_id backend status extended_attributes placed updated >+ illrequest_id backend status status_alias extended_attributes placed updated > ) > ]; > } >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >index bea33ac12b7..034a7de2867 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >@@ -183,7 +183,12 @@ > </li> > <li> > <label for="status">Status:</label> >- [% request.status_alias ? request.statusalias.lib_opac : request.capabilities.$status.name | html %] >+ [% request.capabilities.$status.name | html %] >+ [% IF request.status_alias && request.statusalias.lib_opac %] >+ <i><strong>[% request.statusalias.lib_opac | html %]</strong></i> >+ [% ELSE %] >+ <i><strong>[% request.statusalias.authorised_value | html %]</strong></i> >+ [% END %] > </li> > <li> > <label for="medium">Request type:</label> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39446
:
179684
|
180130
|
180955
|
180999
|
181146
|
182591