Bugzilla – Attachment 18097 Details for
Bug 8840
ubuntu-pkg-check.sh fix and extend functionality
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 8840 - [SIGNED-OFF] Patch to solve false "All dependencies installed!"
PASSED-QA-Bug-8840---SIGNED-OFF-Patch-to-solve-fal.patch (text/plain), 1.91 KB, created by
Katrin Fischer
on 2013-05-12 15:48:31 UTC
(
hide
)
Description:
[PASSED QA] Bug 8840 - [SIGNED-OFF] Patch to solve false "All dependencies installed!"
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-05-12 15:48:31 UTC
Size:
1.91 KB
patch
obsolete
>From bce5be25d95729c4733dd99b3174900d36fb4538 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Mon, 17 Dec 2012 15:51:33 -0500 >Subject: [PATCH] [PASSED QA] Bug 8840 - [SIGNED-OFF] Patch to solve false > "All dependencies installed!" > >Reordered logic to accumulate MISSING_PATCHES variable and tweak >condition to be certain it was not failing. > >Signed-off-by: Magnus Enger <magnus@enger.priv.no> >Works as advertised, see Bugzilla for details. > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >--- > install_misc/ubuntu-packages.sh | 19 +++++++++++-------- > 1 file changed, 11 insertions(+), 8 deletions(-) > >diff --git a/install_misc/ubuntu-packages.sh b/install_misc/ubuntu-packages.sh >index ef2c2c6..33b6642 100755 >--- a/install_misc/ubuntu-packages.sh >+++ b/install_misc/ubuntu-packages.sh >@@ -141,16 +141,19 @@ for PACKAGE in $UBUNTU_PACKAGES; do > # Test if the package is installed > PACKAGE_INSTALLED=`packageInstalled $PACKAGE` > >+ # Determine the package version if it is installed. >+ if [ "$PACKAGE_INSTALLED" == "yes" ]; then >+ PACKAGE_VERSION=`getPackageVersion $PACKAGE` >+ >+ # otherwise default to 'none'. >+ else >+ PACKAGE_VERSION="none" >+ MISSING_PACKAGES="$PACKAGE $MISSING_PACKAGES" >+ fi >+ > # If we are supposed to report... > if [ "$CHECK" == "yes" ]; then > >- # Determine the package version if it is installed. >- if [ "$PACKAGE_INSTALLED" == "yes" ]; then >- PACKAGE_VERSION=`getPackageVersion $PACKAGE` >- # otherwise default to 'none'. >- else >- PACKAGE_VERSION="none" >- fi > > # report the package name and version number. > echo "$PACKAGE = $PACKAGE_VERSION" >@@ -163,7 +166,7 @@ for PACKAGE in $UBUNTU_PACKAGES; do > done > > # If we aren't reporting, then the last echo didn't have a newline. >-if [ "$CHECK" != "yes" ]; then >+if [ ! "$CHECK" == "yes" ]; then > echo > fi > >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8840
:
12566
|
12594
|
12599
|
12610
|
12613
|
13200
|
14171
|
14176
|
14177
|
16539
|
16540
|
18096
| 18097