Bugzilla – Attachment 180970 Details for
Bug 35267
Clarify CSS options for Notices
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35267: (follow-up) Add explanatory note to CSS displays
Bug-35267-follow-up-Add-explanatory-note-to-CSS-di.patch (text/plain), 5.24 KB, created by
Martin Renvoize (ashimema)
on 2025-04-15 14:02:53 UTC
(
hide
)
Description:
Bug 35267: (follow-up) Add explanatory note to CSS displays
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-04-15 14:02:53 UTC
Size:
5.24 KB
patch
obsolete
>From e0f27c422515b328d19b2ab1fcaf38b5391386c0 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Thu, 3 Apr 2025 15:48:38 +0200 >Subject: [PATCH] Bug 35267: (follow-up) Add explanatory note to CSS displays > >This patch adds a simple explanatory note to each of the Notice CSS >display options in the notices template editor page >--- > .../prog/en/modules/tools/letter.tt | 37 ++++++++++++++++--- > 1 file changed, 32 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt >index 4660b70e192..f41dad127ed 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt >@@ -539,14 +539,23 @@ > <!-- /#add_notice --> > > <fieldset class="page-section"> >- <h2>HTML styles</h2> >+ <h2>Global HTML Notice Styles</h2> > [% WRAPPER accordion panelgroup_id="notice_styles" %] > [% WRAPPER accordion_item %] > [% WRAPPER accordion_heading panel_id="all_notice_css" %] > All Notice CSS > [% END %] > [% WRAPPER accordion_panel panel_id="all_notice_css" %] >- <pre><code>[%- Koha.Preference('AllNoticeCSS') | html -%]</code></pre> >+ <p class="alert alert-info">CSS to be applied to all notice types</p> >+ [%- IF Koha.Preference('AllNoticeCSS') -%] >+ <div class="card"> >+ <div class="card-body bg-light"> >+ <pre class="mb-0"><code class="language-css">[%- Koha.Preference('AllNoticeCSS') | html -%]</code></pre> >+ </div> >+ </div> >+ [%- ELSE -%] >+ <p class="alert alert-warning">None defined</p> >+ [%- END -%] > [% IF ( CAN_user_parameters_manage_sysprefs ) %] > <a class="syspref-link" href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=AllNoticeCSS">Edit</a> > [% END %] >@@ -557,7 +566,16 @@ > Email Notice CSS > [% END %] > [% WRAPPER accordion_panel panel_id="email_notice_css" %] >- <pre><code>[%- Koha.Preference('EmailNoticeCSS') | html -%]</code></pre> >+ <p class="alert alert-info">CSS to be applied to email notices in addition to that already in "All Notice CSS"</p> >+ [%- IF Koha.Preference('EmailNoticeCSS') -%] >+ <div class="card"> >+ <div class="card-body bg-light"> >+ <pre><code>[%- Koha.Preference('EmailNoticeCSS') | html -%]</code></pre> >+ </div> >+ </div> >+ [%- ELSE -%] >+ <p class="alert alert-warning">None defined</p> >+ [%- END -%] > [% IF ( CAN_user_parameters_manage_sysprefs ) %] > <a class="syspref-link" href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=EmailNoticeCSS">Edit</a> > [% END %] >@@ -568,7 +586,16 @@ > Print Notice CSS > [% END %] > [% WRAPPER accordion_panel panel_id="print_notice_css" %] >- <pre><code>[%- Koha.Preference('PrintNoticeCSS') | html -%]</code></pre> >+ <p class="alert alert-info">CSS to be applied to print notices in addition to that already in "All Notice CSS"</p> >+ [%- IF Koha.Preference('PrintNoticeCSS') -%] >+ <div class="card"> >+ <div class="card-body bg-light"> >+ <pre><code>[%- Koha.Preference('PrintNoticeCSS') | html -%]</code></pre> >+ </div> >+ </div> >+ [%- ELSE -%] >+ <p class="alert alert-warning">None defined</p> >+ [%- END -%] > [% IF ( CAN_user_parameters_manage_sysprefs ) %] > <a class="syspref-link" href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=PrintNoticeCSS">Edit</a> > [% END %] >@@ -841,7 +868,7 @@ > <div class="panel-heading" role="tab" id="format_[% lang | html %]Heading"> > <h3 class="panel-title"> > <a role="button" class="collapsed" data-bs-toggle="collapse" data-parent="#group_[% lang | html %]" href="#format_[% lang | html %]" aria-expanded="false" aria-controls="format_[% lang | html %]"> >- <span>Format</span> >+ <span>Local HTML Notice Styles</span> > </a> > </h3> > </div> >-- >2.49.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35267
:
172414
|
172415
|
172416
|
172417
|
172418
|
172457
|
172458
|
172459
|
172460
|
172461
|
172462
|
172463
|
172474
|
172475
|
172476
|
172477
|
172478
|
172479
|
172480
|
172485
|
172486
|
172487
|
172488
|
172489
|
172490
|
172491
|
175531
|
175532
|
175533
|
175534
|
175535
|
175536
|
175706
|
175707
|
175708
|
175709
|
175710
|
175711
|
175715
|
175716
|
175717
|
175718
|
175719
|
175721
|
175723
|
175724
|
175725
|
175726
|
175727
|
175728
|
175729
|
178485
|
178486
|
178487
|
178488
|
178489
|
178490
|
178491
|
180574
|
180575
|
180576
|
180577
|
180578
|
180579
|
180580
|
180963
|
180964
|
180965
|
180966
|
180967
|
180968
|
180969
| 180970 |
180971