Bugzilla – Attachment 180971 Details for
Bug 35267
Clarify CSS options for Notices
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35267: (follow-up) Remove 'apply to all' from format
Bug-35267-follow-up-Remove-apply-to-all-from-forma.patch (text/plain), 2.84 KB, created by
Martin Renvoize (ashimema)
on 2025-04-15 14:02:58 UTC
(
hide
)
Description:
Bug 35267: (follow-up) Remove 'apply to all' from format
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-04-15 14:02:58 UTC
Size:
2.84 KB
patch
obsolete
>From 3223766f90312687d83e3bdff6db923abcebb13a Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Thu, 3 Apr 2025 16:34:35 +0200 >Subject: [PATCH] Bug 35267: (follow-up) Remove 'apply to all' from format > >With the introduction of more granular global preferences for notice CSS >we no longer need the somewhat confusing per notice but apply to all >format checkbox. As suggested by Lucas, this patch removes that option. > >This is safe to remove at this stage as the feature in question isn't >really working given the second bug implimenting most of the >functionality to expose it is still in the queue. > >Sponsored-by: Open Fifth <https://openfifth.co.uk> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt | 5 ----- > tools/letter.pl | 7 ------- > 2 files changed, 12 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt >index f41dad127ed..6b999d945a4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt >@@ -889,11 +889,6 @@ > <label for="style_[% lang | html %]">Style (CSS): </label> > <textarea id="style_[% lang | html %]" name="style_[% lang | html %]" rows="15" cols="80">[% letters.$lang.params.style | $raw %]</textarea> > </li> >- <li class="format_all_notices_option"> >- <label for="format_all_[% lang | html %]">Apply format settings to all notices[% IF Koha.Preference('TranslateNotices') %]for this language[% END %]:</label> >- <input type="checkbox" name="format_all_[% lang | html %]" id="format_all_[% lang | html %]" class="format_all" value="1" /> >- <span class="hint">Existing format settings will be overwritten.</span> >- </li> > </ol> > </div> > </fieldset> >diff --git a/tools/letter.pl b/tools/letter.pl >index 0d409850b96..081063e6785 100755 >--- a/tools/letter.pl >+++ b/tools/letter.pl >@@ -328,13 +328,6 @@ sub add_validate { > for my $mtt (@mtt) { > my $lang = shift @lang; > my $style = $input->param("style_$lang"); >- my $format_all = $input->param("format_all_$lang"); >- if ($format_all) { >- my @letters = Koha::Notice::Templates->search( { lang => $lang } )->as_list; >- foreach my $letter (@letters) { >- $letter->set( { style => $style } )->store; >- } >- } > my $is_html = $input->param("is_html_$mtt\_$lang"); > my $title = shift @title; > my $content = shift @content; >-- >2.49.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35267
:
172414
|
172415
|
172416
|
172417
|
172418
|
172457
|
172458
|
172459
|
172460
|
172461
|
172462
|
172463
|
172474
|
172475
|
172476
|
172477
|
172478
|
172479
|
172480
|
172485
|
172486
|
172487
|
172488
|
172489
|
172490
|
172491
|
175531
|
175532
|
175533
|
175534
|
175535
|
175536
|
175706
|
175707
|
175708
|
175709
|
175710
|
175711
|
175715
|
175716
|
175717
|
175718
|
175719
|
175721
|
175723
|
175724
|
175725
|
175726
|
175727
|
175728
|
175729
|
178485
|
178486
|
178487
|
178488
|
178489
|
178490
|
178491
|
180574
|
180575
|
180576
|
180577
|
180578
|
180579
|
180580
|
180963
|
180964
|
180965
|
180966
|
180967
|
180968
|
180969
|
180970
| 180971