Bugzilla – Attachment 181090 Details for
Bug 36197
Allow unauthenticated ILL requests in the OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36197: (QA follow-up): Fix backends filtering in opac_available_backends
Bug-36197-QA-follow-up-Fix-backends-filtering-in-o.patch (text/plain), 1.50 KB, created by
Tomás Cohen Arazi (tcohen)
on 2025-04-17 13:40:35 UTC
(
hide
)
Description:
Bug 36197: (QA follow-up): Fix backends filtering in opac_available_backends
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2025-04-17 13:40:35 UTC
Size:
1.50 KB
patch
obsolete
>From 27347e3bec3d572ce033969004a44f3ab7426c49 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Fri, 17 Jan 2025 11:01:39 -0100 >Subject: [PATCH] Bug 36197: (QA follow-up): Fix backends filtering in > opac_available_backends > >This was incorrectly keeping backends that don't support unauthenticated ILL requests if more than one existed. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/ILL/Request/Config.pm | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > >diff --git a/Koha/ILL/Request/Config.pm b/Koha/ILL/Request/Config.pm >index 2605516547a..288685b43b0 100644 >--- a/Koha/ILL/Request/Config.pm >+++ b/Koha/ILL/Request/Config.pm >@@ -178,11 +178,12 @@ sub opac_available_backends { > my $reduced = C4::Context->preference('ILLOpacbackends'); > my $backends = $self->available_backends($reduced); > if ( !$loggedinuser && C4::Context->preference('ILLOpacUnauthenticatedRequest') ) { >- foreach my $backend ( @{$backends} ) { >- my $loaded_b = Koha::ILL::Request->new->load_backend($backend); >- @$backends = grep { !/$backend/ } @$backends >- if ( $loaded_b->_backend_capability('opac_unauthenticated_ill_requests') == 0 ); >- } >+ $backends = [ >+ grep { >+ my $loaded_b = Koha::ILL::Request->new->load_backend($_); >+ $loaded_b->_backend_capability('opac_unauthenticated_ill_requests') >+ } @$backends >+ ]; > } > return $backends; > } >-- >2.49.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36197
:
171358
|
171359
|
171360
|
171361
|
171362
|
171363
|
171364
|
171365
|
171366
|
171367
|
171368
|
171369
|
171370
|
171371
|
174495
|
174496
|
174497
|
174498
|
174499
|
174500
|
174501
|
174502
|
174503
|
174504
|
174505
|
174506
|
174507
|
174508
|
176564
|
176565
|
176680
|
176723
|
176724
|
176726
|
176727
|
179764
|
179765
|
179766
|
179767
|
179769
|
179770
|
179771
|
179772
|
179773
|
179774
|
179775
|
179776
|
179777
|
179778
|
179779
|
179780
|
179781
|
179782
|
179783
|
179784
|
179785
|
180850
|
180851
|
180852
|
180853
|
180854
|
180855
|
180856
|
180857
|
180858
|
180859
|
180860
|
180861
|
180862
|
180863
|
180864
|
180865
|
180866
|
180867
|
180868
|
180869
|
180870
|
180871
|
180872
|
180873
|
181073
|
181074
|
181075
|
181076
|
181077
|
181078
|
181079
|
181080
|
181081
|
181082
|
181083
|
181084
|
181085
|
181086
|
181087
|
181088
|
181089
| 181090 |
181091
|
181092
|
181093
|
181094
|
181095
|
181096
|
181097
|
181098
|
181592