Bugzilla – Attachment 181131 Details for
Bug 39633
Inventory tool DataTable doesn't properly load
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39633: Use column names to get table settings
Bug-39633-Use-column-names-to-get-table-settings.patch (text/plain), 3.46 KB, created by
Biblibre Sandboxes
on 2025-04-17 19:03:54 UTC
(
hide
)
Description:
Bug 39633: Use column names to get table settings
Filename:
MIME Type:
Creator:
Biblibre Sandboxes
Created:
2025-04-17 19:03:54 UTC
Size:
3.46 KB
patch
obsolete
>From 4fc065269fd42be217881a3c9451f4aea0e04fb9 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Mon, 14 Apr 2025 20:15:56 +0000 >Subject: [PATCH] Bug 39633: Use column names to get table settings > >1. Cataloging > Inventory >2. Run the tool without uploaded barcodes >3. Table loads and you see all the DataTable controls ( Table settings, etc ) >4. Run the tool while uploading at least 1 barcode >5. No DataTable controls >6. APPLY PATCH >7. Try steps 1 -4 again, making sure everything now works. > >Signed-off-by: Sam <sam.sowanick@corvallisoregon.gov> >--- > .../prog/en/modules/tools/inventory.tt | 29 ++++++++++--------- > 1 file changed, 15 insertions(+), 14 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt >index 4b028bafde..2c57ed762f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt >@@ -307,19 +307,19 @@ > <thead> > <tr> > [% UNLESS uploadedbarcodesflag %] >- <th>Seen</th> >+ <th id="seen" data-colname="seen">Seen</th> > [% END %] >- <th>Barcode</th> >- <th>Call number</th> >- <th>Library</th> >- <th>Collection</th> >- <th class="anti-the">Title</th> >- <th>Not for loan</th> >- <th>Lost</th> >- <th>Damaged</th> >- <th>Withdrawn</th> >- <th>Last seen</th> >- <th>Problems</th> >+ <th id="barcode" data-colname="barcode">Barcode</th> >+ <th id="call_number" data-colname="call_number">Call number</th> >+ <th id="library" data-colname="library">Library</th> >+ <th id="collection" data-colname="collection">Collection</th> >+ <th id="title" data-colname="title" class="anti-the">Title</th> >+ <th id="notforloan" data-colname="notforloan">Not for loan</th> >+ <th id="lost" data-colname="lost">Lost</th> >+ <th id="damaged" data-colname="damaged">Damaged</th> >+ <th id="withdrawn" data-colname="withdrawn">Withdrawn</th> >+ <th id="last_seen" data-colname="last_seen">Last seen</th> >+ <th id="problems" data-colname="problems">Problems</th> > </tr> > </thead> > <tbody> >@@ -462,9 +462,10 @@ > var table_settings = [% TablesSettings.GetTableSettings( 'tools', 'inventory', 'inventoryt', 'json' ) | $raw %]; > inventorydt = $("#inventoryt").kohaTable({ > "pagingType": 'full_numbers', >- [% IF compareinv2barcd %] >+ "bKohaColumnsUseNames": true, >+ [% IF uploadedbarcodesflag %] > // sort on callnumber >- "order": [[ 1, "asc" ]], >+ "order": [[ 2, "asc" ]], > [% ELSE %] > // first column contains checkboxes > "columnDefs": [ >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39633
:
180939
|
181131
|
181147
|
181252