Bugzilla – Attachment 181137 Details for
Bug 39624
Add an "All" patron category option for the "Default open article requests limit" circulation rules
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39624: Add patron category * (All) to open_article_requests limit
Bug-39624-Add-patron-category--All-to-openarticler.patch (text/plain), 2.52 KB, created by
Lucas Gass (lukeg)
on 2025-04-17 19:36:39 UTC
(
hide
)
Description:
Bug 39624: Add patron category * (All) to open_article_requests limit
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2025-04-17 19:36:39 UTC
Size:
2.52 KB
patch
obsolete
>From 4f1328cef0c4941a101e83dca978488f0630ebbe Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 14 Apr 2025 08:03:58 +0000 >Subject: [PATCH] Bug 39624: Add patron category * (All) to > open_article_requests limit > >Test plan: >Go to smart rules. >Add a limit for All. >Refresh and check if it is still there. >Enable ArticleRequests and verify if the limit is working. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > .../intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >index 9ce8a43dbd2..169b6defd49 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >@@ -984,13 +984,16 @@ > <th> </th> > </tr> > [% FOREACH c IN categorycodes %] >- [% NEXT UNLESS c %] > [% SET i = undef %] > [% SET open_article_requests_limit = all_rules.$c.$i.open_article_requests_limit %] > > [% IF ( open_article_requests_limit.defined && open_article_requests_limit != '' ) %] > <tr> >- <td> [% Categories.GetName(c) | html %] </td> >+ [% IF c == undef %] >+ <td><em>All</em></td> >+ [% ELSE %] >+ <td> [% Categories.GetName(c) | html %] </td> >+ [% END %] > <td> > [% IF open_article_requests_limit.defined && open_article_requests_limit != '' %] > [% open_article_requests_limit | html %] >@@ -1008,6 +1011,7 @@ > <tr> > <td> > <select name="categorycode"> >+ <option value="*">All</option> > [% FOREACH patron_category IN patron_categories %] > <option value="[% patron_category.categorycode | html %]">[% patron_category.description | html %]</option> > [% END %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39624
:
180901
|
180961
|
180997
|
180998
| 181137 |
181138