Bugzilla – Attachment 181147 Details for
Bug 39633
Inventory tool DataTable doesn't properly load
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37784: (QA follow-up) Add few tables to Koha::Database::Columns
Bug-37784-QA-follow-up-Add-few-tables-to-KohaDatab.patch (text/plain), 1.81 KB, created by
Marcel de Rooy
on 2025-04-18 06:47:07 UTC
(
hide
)
Description:
Bug 37784: (QA follow-up) Add few tables to Koha::Database::Columns
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2025-04-18 06:47:07 UTC
Size:
1.81 KB
patch
obsolete
>From 3a7fb5852f312fb70ccf47022a66e47aca1d1956 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 14 Mar 2025 08:40:30 +0000 >Subject: [PATCH] Bug 37784: (QA follow-up) Add few tables to > Koha::Database::Columns >Content-Type: text/plain; charset=utf-8 > >This resolves exceptions like: >Invalid table name accountlines at /usr/share/koha/C4/Reports/Guided.pm line 216. > >Test plan: >Go to reports/dictionary.pl >Try to add a new definition for Serials. >Without this patch, you would crash (status 500). >Run t/Koha/Database/Columns.t > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > Koha/Database/Columns.pm | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > >diff --git a/Koha/Database/Columns.pm b/Koha/Database/Columns.pm >index d23d7cc871..f96f05c430 100644 >--- a/Koha/Database/Columns.pm >+++ b/Koha/Database/Columns.pm >@@ -34,7 +34,8 @@ Koha::Database::Columns > =head3 columns > > Static method that returns a hashref with mappings from column names >-to descriptions, for several tables. Currently >+to descriptions for several tables. >+Should be extended. > > =over > >@@ -60,6 +61,14 @@ to descriptions, for several tables. Currently > > sub columns { > return { >+ # TODO stub for the check in C4::Reports::Guided, get_columns (see BZ 37784) >+ accountlines => {}, >+ serial => {}, >+ serialitems => {}, >+ subscriptionhistory => {}, >+ subscriptionroutinglist => {}, >+ aqbooksellers => {}, >+ > aqorders => { > "basketno" => __("Basket ID (internal)"), > "biblionumber" => __("Biblio number (internal)"), >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39633
:
180939
|
181131
|
181147
|
181252