Bugzilla – Attachment 181157 Details for
Bug 14250
Don't allow generating discharges for patrons with fines
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14250: (QA follow-up) Small changes
Bug-14250-QA-follow-up-Small-changes.patch (text/plain), 2.28 KB, created by
Marcel de Rooy
on 2025-04-18 09:23:44 UTC
(
hide
)
Description:
Bug 14250: (QA follow-up) Small changes
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2025-04-18 09:23:44 UTC
Size:
2.28 KB
patch
obsolete
>From bb9bc9a1f4a65bc48fb1824b75504dd924963998 Mon Sep 17 00:00:00 2001 >From: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> >Date: Fri, 18 Apr 2025 10:30:31 +0200 >Subject: [PATCH] Bug 14250: (QA follow-up) Small changes >Content-Type: text/plain; charset=utf-8 > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >[EDIT] Changed commit title. Tidied opac script. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/discharge.tt | 5 +---- > opac/opac-discharge.pl | 3 +-- > 2 files changed, 2 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/discharge.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/discharge.tt >index 88f85eadcb..9d9d1497ca 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/discharge.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/discharge.tt >@@ -53,7 +53,7 @@ > </div> > [% END %] > [% UNLESS can_be_discharged %] >- <p>A discharge cannot be generated for this patron because:</p> >+ <p>A discharge cannot be generated for this patron for following reasons:</p> > <ul> > [% IF discharge_problems.checkouts %] > <li>The patron has [% discharge_problems.checkouts | html %] item(s) checked out</li> >@@ -68,9 +68,6 @@ > <p>The patron has holds. The holds will be cancelled if the discharge is generated.</p> > [% END %] > >- [% IF discharge_problems.debt %] >- <li>The patron has unpaid charges of [% discharge_problems.debt | $Price %]</li> >- [% END %] > <div class="btn-toolbar"> > <form method="post"> > [% INCLUDE 'csrf-token.inc' %] >diff --git a/opac/opac-discharge.pl b/opac/opac-discharge.pl >index cc79467382..7edf18a623 100755 >--- a/opac/opac-discharge.pl >+++ b/opac/opac-discharge.pl >@@ -47,8 +47,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( > > my ( $can_be_discharged, $discharge_problems ) = > Koha::Patron::Discharge::can_be_discharged( { borrowernumber => $loggedinuser } ); >-my $patron = Koha::Patrons->find($loggedinuser); >-my $has_pending_checkouts = $patron->checkouts->count; >+my $patron = Koha::Patrons->find($loggedinuser); > > $template->param( > can_be_discharged => $can_be_discharged, >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14250
:
170136
|
170228
|
170581
|
170607
|
170662
|
170663
|
170664
|
170705
|
170706
|
170707
|
170708
|
171025
|
171026
|
171271
|
171272
|
171273
|
171274
|
171275
|
171276
|
179617
|
179618
|
179619
|
179620
|
179621
|
179622
|
181149
|
181150
|
181154
|
181156
| 181157