Bugzilla – Attachment 181160 Details for
Bug 39679
Missing space before barcode in holds table with item-specific hold
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39679: Add space before barcode in holds table
Bug-39679-Add-space-before-barcode-in-holds-table.patch (text/plain), 2.52 KB, created by
Andrew Fuerste-Henry
on 2025-04-18 14:27:14 UTC
(
hide
)
Description:
Bug 39679: Add space before barcode in holds table
Filename:
MIME Type:
Creator:
Andrew Fuerste-Henry
Created:
2025-04-18 14:27:14 UTC
Size:
2.52 KB
patch
obsolete
>From d024da972e5c37f5cd91f7fdf4528abaeea84ca3 Mon Sep 17 00:00:00 2001 >From: Andrew Fuerste Henry <andrew@bywatersolutions.com> >Date: Fri, 18 Apr 2025 14:25:13 +0000 >Subject: [PATCH] Bug 39679: Add space before barcode in holds table > >To test: >1 : place an item-level hold for an item with a barcode >2 : in the holds list on request.pl, see that the Details column for your hold lists "Only item[barcode]" in the dropdown without a space before the barcode >3 : place a second item-level hold for the same patron >4 : back on the holds list, see that the Details column isn't a dropdown anymore but still says "Only item[barcode]" without a space >5 : apply patch, restart_all, reload page >6 : confirm your hold has a space before the barcode while not in a dropdown >7 : cancel your hold from step 3 >8 : confirm your hold has a space before the barcode when in a dropdown >--- > koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >index 2d65e83dc1..221c2e2719 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >@@ -221,7 +221,7 @@ > <span>Only item</span> > <a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% hold.biblionumber | uri %]&itemnumber=[% hold.itemnumber | uri %]#item[% hold.itemnumber | uri %]"> > [%- IF ( hold.barcodenumber ) -%] >- [%- hold.barcodenumber | html -%] >+ <span>[%- hold.barcodenumber | html -%]</span> > [%- ELSE -%] > <span>No barcode</span> > [%- END -%] >@@ -232,7 +232,7 @@ > <option selected="selected" value="" > >Only item > [%- IF ( hold.barcodenumber ) -%] >- [%- hold.barcodenumber | html -%] >+ <span>[%- hold.barcodenumber | html -%]</span> > [%- ELSE -%] > No barcode > [%- END -%] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39679
:
181160
|
181168
|
181204
|
182091
|
182092
|
182120
|
182228
|
182253