Bugzilla – Attachment 181187 Details for
Bug 39490
Table columns missing headings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39490: Table Columns Missing Headings
Bug-39490-Table-Columns-Missing-Headings.patch (text/plain), 3.58 KB, created by
Lucas Gass (lukeg)
on 2025-04-18 15:34:36 UTC
(
hide
)
Description:
Bug 39490: Table Columns Missing Headings
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2025-04-18 15:34:36 UTC
Size:
3.58 KB
patch
obsolete
>From d027fdb7d8c0a45bce6b987c75485dcb9611facf Mon Sep 17 00:00:00 2001 >From: Alexander Blanchard <alexander.blanchard@openfifth.co.uk> >Date: Mon, 7 Apr 2025 11:33:02 +0000 >Subject: [PATCH] Bug 39490: Table Columns Missing Headings > >An accessibility audit highlighted that the purchase suggestions >and search history tables in the 'My Account' section do not >have headings in the tickbox column. The report suggests headings >should be added to support those using screen readers. > >To Test: >1) In the opac, navigate to 'Your Account' >2) Navigate to 'Purchase Suggestions' >3) Add a purchase suggestion if you currently have none >4) Note that the left column does not have a heading and you cannot tab to it >5) Navigate to 'Search History' >6) Note, you must have searched the catalogue at least once for this table to display >7) Note that the left column does not have a heading and you cannot tab to it >8) Apply the patch >9) Repeat the steps above >10) Note that the tables now have a tooltip with information relevant to the column >11) Note that this column heading can now be tabbed to > >Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > .../opac-tmpl/bootstrap/en/modules/opac-search-history.tt | 4 +++- > .../opac-tmpl/bootstrap/en/modules/opac-suggestions.tt | 6 +++++- > 2 files changed, 8 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt >index 068703ae32a..d5ef75e9725 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt >@@ -91,7 +91,9 @@ > <caption class="sr-only">Current session</caption> > <thead> > <tr> >- <th></th> >+ <th> >+ <i data-bs-toggle="tooltip" title="Check the boxes in this column to select searches for deletion" data-bs-placement="right" class="fa fa-info-circle" tabindex="0"></i> >+ </th> > <th>Date</th> > <th>Search</th> > <th>Results</th> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >index ce995218f98..ed9b16e100f 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >@@ -415,7 +415,11 @@ > <caption class="sr-only">Your purchase suggestions</caption> > <thead> > <tr> >- [% IF ( loggedinusername ) %]<th> </th>[% END %] >+ [% IF ( loggedinusername ) %] >+ <th> >+ <i data-bs-toggle="tooltip" title="Check the boxes in this column to select purchase suggestions for deletion" data-bs-placement="right" class="fa fa-info-circle" tabindex="0"></i> >+ </th> >+ [% END %] > <th class="all">Summary</th> > <th>Suggested on</th> > <th>Note</th> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39490
:
180691
|
180707
| 181187