Bugzilla – Attachment 181193 Details for
Bug 39501
Incorrect relationship code chosen when linking authorities with other authorities
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39501: add "value=" attributes to the HTML select element
Bug-39501-add-value-attributes-to-the-HTML-select-.patch (text/plain), 9.27 KB, created by
Lucas Gass (lukeg)
on 2025-04-18 19:39:55 UTC
(
hide
)
Description:
Bug 39501: add "value=" attributes to the HTML select element
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2025-04-18 19:39:55 UTC
Size:
9.27 KB
patch
obsolete
>From 99bcc10631d48b70db0abe0a69d26fb9e44f5518 Mon Sep 17 00:00:00 2001 >From: Andreas Roussos <a.roussos@dataly.gr> >Date: Mon, 31 Mar 2025 14:17:42 +0000 >Subject: [PATCH] Bug 39501: add "value=" attributes to the HTML select element > >In the current main branch, when linking authorities with other >authorities, if you select a relationship you no longer get the >associated letter (i.e. the "relationship code") copied to the >appropriate subfield. Rather, the whole description gets copied. > >This patch fixes that. > >Test plan: > >0) [PREREQUISITES in order for the authority finder plugin to come up] > a) You must have at least one authority type besides the 'Default'. > b) View the MARC structure of the 'Default' auth type, then click > on 'Actions->Subfields' for tag 500; click on 'Edit subfields'. > Select the subfield 'a' tab, then pick an auth type from the > 'Thesaurus:' dropdown menu; click 'Save changes' at the top. > >1) In the Staff client, go to Authorities, then click 'New Authority' > and pick the 'Default' authority type (or edit an existing auth). > >2) When the authority editor comes up, go to tag 500 and expand it. > >3) Click on the ellipsis (...) next to subfield $a. > >4) When the authority finder comes up, search for an authority, pick > a relator code from the 'Special relationship:' dropdown, and then > click on the 'Choose' button for one of the authorities you found. > >5) Notice that the whole description for the relationship you selected > gets copied (instead of just the single letter relationship code). > >6) Apply this patch. > >7) Repeat steps 1-4. > Notice that, this time, only the relationship code gets copied over. > >Signed-off-by: Laurence <laurence.rault@biblibre.com> >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > .../prog/en/includes/auth-finder-search.inc | 54 +++++++++---------- > 1 file changed, 27 insertions(+), 27 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/auth-finder-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/auth-finder-search.inc >index 0c5965a250c..d3bd1d9be29 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/auth-finder-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/auth-finder-search.inc >@@ -153,34 +153,34 @@ > [% selected=relationship | html %] > <option>None specified</option> > [% IF Koha.Preference('marcflavour') == 'MARC21' %] >- <option [% IF selected == 'a' %]selected="selected"[% END %]>a - Earlier heading</option> >- <option [% IF selected == 'b' %]selected="selected"[% END %]>b - Later heading</option> >- <option [% IF selected == 'd' %]selected="selected"[% END %]>d - Acronym</option> >- <option [% IF selected == 'f' %]selected="selected"[% END %]>f - Musical composition</option> >- <option [% IF selected == 'g' %]selected="selected"[% END %]>g - Broader term</option> >- <option [% IF selected == 'h' %]selected="selected"[% END %]>h - Narrower term</option> >- <option [% IF selected == 'i' %]selected="selected"[% END %]>i - Reference instruction phrase in subfield $i</option> >- <option [% IF selected == 'n' %]selected="selected"[% END %]>n - Not applicable</option> >- <option [% IF selected == 'r' %]selected="selected"[% END %]>r - Relationship designation in $i or $4</option> >- <option [% IF selected == 't' %]selected="selected"[% END %]>t - Immediate parent body</option> >+ <option [% IF selected == 'a' %]selected="selected"[% END %] value="a">a - Earlier heading</option> >+ <option [% IF selected == 'b' %]selected="selected"[% END %] value="b">b - Later heading</option> >+ <option [% IF selected == 'd' %]selected="selected"[% END %] value="d">d - Acronym</option> >+ <option [% IF selected == 'f' %]selected="selected"[% END %] value="f">f - Musical composition</option> >+ <option [% IF selected == 'g' %]selected="selected"[% END %] value="g">g - Broader term</option> >+ <option [% IF selected == 'h' %]selected="selected"[% END %] value="h">h - Narrower term</option> >+ <option [% IF selected == 'i' %]selected="selected"[% END %] value="i">i - Reference instruction phrase in subfield $i</option> >+ <option [% IF selected == 'n' %]selected="selected"[% END %] value="n">n - Not applicable</option> >+ <option [% IF selected == 'r' %]selected="selected"[% END %] value="r">r - Relationship designation in $i or $4</option> >+ <option [% IF selected == 't' %]selected="selected"[% END %] value="t">t - Immediate parent body</option> > [% ELSIF Koha.Preference('marcflavour') == 'UNIMARC' %] >- <option [% IF selected == 'a' %]selected="selected"[% END %]>a = earlier name</option> >- <option [% IF selected == 'b' %]selected="selected"[% END %]>b = later name</option> >- <option [% IF selected == 'c' %]selected="selected"[% END %]>c = official name</option> >- <option [% IF selected == 'd' %]selected="selected"[% END %]>d = acronym / initial / abbreviation</option> >- <option [% IF selected == 'e' %]selected="selected"[% END %]>e = pseudonym</option> >- <option [% IF selected == 'f' %]selected="selected"[% END %]>f = real name</option> >- <option [% IF selected == 'g' %]selected="selected"[% END %]>g = broader term or name</option> >- <option [% IF selected == 'h' %]selected="selected"[% END %]>h = narrower term or name</option> >- <option [% IF selected == 'i' %]selected="selected"[% END %]>i = name in religion</option> >- <option [% IF selected == 'j' %]selected="selected"[% END %]>j = married name</option> >- <option [% IF selected == 'k' %]selected="selected"[% END %]>k = name before marriage</option> >- <option [% IF selected == 'l' %]selected="selected"[% END %]>l = shared pseudonym</option> >- <option [% IF selected == 'm' %]selected="selected"[% END %]>m = secular name</option> >- <option [% IF selected == 'n' %]selected="selected"[% END %]>n = different rule form of a name</option> >- <option [% IF selected == 'o' %]selected="selected"[% END %]>o = attributed name / conventional title of a work</option> >- <option [% IF selected == 'x' %]selected="selected"[% END %]>x = not applicable</option> >- <option [% IF selected == 'z' %]selected="selected"[% END %]>z = other</option> >+ <option [% IF selected == 'a' %]selected="selected"[% END %] value="a">a = earlier name</option> >+ <option [% IF selected == 'b' %]selected="selected"[% END %] value="b">b = later name</option> >+ <option [% IF selected == 'c' %]selected="selected"[% END %] value="c">c = official name</option> >+ <option [% IF selected == 'd' %]selected="selected"[% END %] value="d">d = acronym / initial / abbreviation</option> >+ <option [% IF selected == 'e' %]selected="selected"[% END %] value="e">e = pseudonym</option> >+ <option [% IF selected == 'f' %]selected="selected"[% END %] value="f">f = real name</option> >+ <option [% IF selected == 'g' %]selected="selected"[% END %] value="g">g = broader term or name</option> >+ <option [% IF selected == 'h' %]selected="selected"[% END %] value="h">h = narrower term or name</option> >+ <option [% IF selected == 'i' %]selected="selected"[% END %] value="i">i = name in religion</option> >+ <option [% IF selected == 'j' %]selected="selected"[% END %] value="j">j = married name</option> >+ <option [% IF selected == 'k' %]selected="selected"[% END %] value="k">k = name before marriage</option> >+ <option [% IF selected == 'l' %]selected="selected"[% END %] value="l">l = shared pseudonym</option> >+ <option [% IF selected == 'm' %]selected="selected"[% END %] value="m">m = secular name</option> >+ <option [% IF selected == 'n' %]selected="selected"[% END %] value="n">n = different rule form of a name</option> >+ <option [% IF selected == 'o' %]selected="selected"[% END %] value="o">o = attributed name / conventional title of a work</option> >+ <option [% IF selected == 'x' %]selected="selected"[% END %] value="x">x = not applicable</option> >+ <option [% IF selected == 'z' %]selected="selected"[% END %] value="z">z = other</option> > [% END %] > </select> > </li> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39501
:
180049
|
180054
|
180413
| 181193