Bugzilla – Attachment 18127 Details for
Bug 10052
Make intranetstylesheet and intranetcolorstylesheet behave exactly like their opac counterparts
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 10052: QA Followup
PASSED-QA-Bug-10052-QA-Followup.patch (text/plain), 1.42 KB, created by
Katrin Fischer
on 2013-05-14 06:29:57 UTC
(
hide
)
Description:
[PASSED QA] Bug 10052: QA Followup
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-05-14 06:29:57 UTC
Size:
1.42 KB
patch
obsolete
>From c2636e8102b56af4a499fc1eb6f24520a0fc6a39 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 13 May 2013 09:05:55 +0200 >Subject: [PATCH] [PASSED QA] Bug 10052: QA Followup > >As Katrin pointed out, the intranetstylesheet setting was not respected in the >help pages. The script help.pl does not use get_template_and_user which sets >these variables via Auth.pm but calls gettemplate. >This makes it necessary to 'manually' set them. This patch does that. >Evidently, this could be the case for some other templates vars too.. > >Test plan: >Apply all patches for 10052. >Change intranetstylesheet. Check a help page. >Change intranetcolorstylesheet. Check a help page. > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Looks all good to me now. >Passes tests and still no string changes. >--- > help.pl | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > >diff --git a/help.pl b/help.pl >index f641fe6..fde99d9 100755 >--- a/help.pl >+++ b/help.pl >@@ -55,6 +55,10 @@ unless ( -e "$htdocs/$theme/$lang/modules/$from" ) { > } > > my $template = C4::Templates::gettemplate($from, 'intranet', $query); >-$template->param( referer => $refer ); >+$template->param( >+ referer => $refer, >+ intranetstylesheet => C4::Context->preference("intranetstylesheet"), >+ intranetcolorstylesheet => C4::Context->preference("intranetcolorstylesheet"), >+); > > output_html_with_http_headers $query, "", $template->output; >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10052
:
17441
|
17442
|
17443
|
17444
|
17445
|
17446
|
17465
|
17918
|
17919
|
17920
|
18109
|
18110
|
18111
|
18112
|
18124
|
18125
|
18126
| 18127