Bugzilla – Attachment 181291 Details for
Bug 36154
Add the ability for some pages to be able to use images coming from plugin
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36154: Display images coming from plugin
Bug-36154-Display-images-coming-from-plugin.patch (text/plain), 10.39 KB, created by
Shi Yao Wang
on 2025-04-22 15:31:26 UTC
(
hide
)
Description:
Bug 36154: Display images coming from plugin
Filename:
MIME Type:
Creator:
Shi Yao Wang
Created:
2025-04-22 15:31:26 UTC
Size:
10.39 KB
patch
obsolete
>From d8718e4c9fea417bb12a46519276af2582bdf7b6 Mon Sep 17 00:00:00 2001 >From: Hammat Wele <hammat.wele@inlibro.com> >Date: Wed, 26 Jun 2024 15:03:30 +0000 >Subject: [PATCH] Bug 36154: Display images coming from plugin > >this patch makes the summary page(opac-user), the list pages (opac-shelves.pl, shelves.pl), the Checkout history page (opac-readingrecord.pl) and shelfbrowser to be able to display images coming from plugin. > >https://bugs.koha-community.org/show_bug.cgi?id=37916 >--- > .../opac-tmpl/bootstrap/en/includes/shelfbrowser.inc | 6 ++++-- > .../bootstrap/en/modules/opac-readingrecord.tt | 5 ++++- > .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 3 ++- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 11 +++++++---- > 4 files changed, 17 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc >index 280e76cfb1..bf0ba682ae 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc >@@ -32,14 +32,16 @@ > [% img_title = item.biblionumber %] > [% END %] > >- [% IF ( OPACLocalCoverImages || OPACAmazonCoverImages || ( SyndeticsEnabled && SyndeticsCoverImages ) || GoogleJackets || BakerTaylorEnabled || ( Koha.Preference('OpacCoce') && Koha.Preference('CoceProviders') ) || ( Koha.Preference('OPACCustomCoverImages') AND Koha.Preference('CustomCoverImagesURL') ) ) %] >+ [% IF ( OPACLocalCoverImages || OPACAmazonCoverImages || ( SyndeticsEnabled && SyndeticsCoverImages ) || GoogleJackets || BakerTaylorEnabled || ( Koha.Preference('OpacCoce') && Koha.Preference('CoceProviders') ) || ( Koha.Preference('OPACCustomCoverImages') AND Koha.Preference('CustomCoverImagesURL') ) || CoverImagePlugins ) %] > <a > class="shelfbrowser_cover" > href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% item.biblionumber | uri %]&shelfbrowse_itemnumber=[% item.itemnumber | uri %]#shelfbrowser" > data-isbn="[% item.browser_normalized_isbn | html %]" > > > [% IF ( OPACLocalCoverImages ) %] >- <div title="[% img_title | html %]" class="[% item.biblionumber | html %] thumbnail-shelfbrowser" id="local-thumbnail-shelf-[% item.biblionumber | html %]"></div> >+ <div title="[% img_title | html %]" class="[% item.biblionumber | html %] thumbnail-shelfbrowser" id="local-thumbnail-shelf-[% item.biblionumber | html %]"> >+ <img src="/cgi-bin/koha/opac-image.pl?thumbnail=1&biblionumber=[% item.biblionumber | uri %]" alt="Local cover image" /> >+ </div> > [% END %] > [% IF ( OPACAmazonCoverImages ) %] > [% IF ( item.browser_normalized_isbn ) %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt >index f3775159ac..99322838ad 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt >@@ -5,8 +5,10 @@ > [% USE AdditionalContents %] > [% USE Asset %] > [% USE Price %] >+[% USE KohaPlugins %] > [% SET OpacNav = AdditionalContents.get( location => "OpacNav", lang => lang, library => logged_in_user.branchcode || default_branch, blocktitle => 0 ) %] > [% SET OpacNavBottom = AdditionalContents.get( location => "OpacNavBottom", lang => lang, library => logged_in_user.branchcode || default_branch, blocktitle => 0 ) %] >+[% SET CoverImagePlugins = KohaPlugins.get_plugins_opac_cover_images %] > [% INCLUDE 'doc-head-open.inc' %] > <title>Your checkout history › [% IF ( LibraryNameTitle ) %][% LibraryNameTitle | html %][% ELSE %]Koha online[% END %] catalog</title> > [% INCLUDE 'doc-head-close.inc' %] >@@ -137,7 +139,7 @@ > [% END %] > [% issuetype | html %] > </td> >- <td> >+ <td data-biblionumber="[% biblio.biblionumber | html %]"> > [% SET normalized_isbn = biblio.normalized_isbn %] > [% IF Koha.Preference('OPACAmazonCoverImages') %] > [% IF normalized_isbn %] >@@ -221,6 +223,7 @@ > [% INCLUDE 'opac-bottom.inc' %] > [% BLOCK jsinclude %] > [% INCLUDE 'datatables.inc' %] >+ [% CoverImagePlugins | $raw %] > <script> > $(document).ready(function(){ > [% IF ( GoogleJackets ) %]KOHA.Google.GetCoverFromIsbn();[% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >index a6f76a74f7..9a798fa1dc 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >@@ -419,7 +419,7 @@ > data-isbn="[% itemsloo.normalized_isbn | html %]" > data-title="[% img_title | html %]" > > >- [% IF ( OPACLocalCoverImages ) %] >+ [% IF ( OPACLocalCoverImages && itemsloo.biblio_object.cover_images.count > 0 ) %] > <span title="[% img_title | html %]" class="[% itemsloo.biblionumber | html %]" id="local-thumbnail[% loop.count | html %]"></span> > [% END %] > >@@ -869,6 +869,7 @@ > [% IF OpenLibraryCovers || OpenLibrarySearch %] > [% Asset.js("js/openlibrary.js") | $raw %] > [% END %] >+ [% CoverImagePlugins | $raw %] > <script> > const loggedinusername = [% ( loggedinusername ) ? 1 : 0 | html %]; > const opacbookbag = [% ( opacbookbag ) ? 1 : 0 | html %]; >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >index 852e6be2d4..2fc79fc3f7 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >@@ -8,9 +8,11 @@ > [% USE Price %] > [% USE AuthorisedValues %] > [% USE AdditionalContents %] >+[% USE KohaPlugins %] > [% SET OpacNav = AdditionalContents.get( location => "OpacNav", lang => lang, library => logged_in_user.branchcode || default_branch, blocktitle => 0 ) %] > [% SET OpacNavBottom = AdditionalContents.get( location => "OpacNavBottom", lang => lang, library => logged_in_user.branchcode || default_branch, blocktitle => 0 ) %] > [% SET OpacMySummaryNote = AdditionalContents.get( location => "OpacMySummaryNote", lang => lang, library => branchcode ) %] >+[% SET CoverImagePlugins = KohaPlugins.get_plugins_opac_cover_images %] > [% SET borrower_club_enrollments = logged_in_user.get_club_enrollments %] > [% SET borrower_enrollable_clubs = logged_in_user.get_enrollable_clubs(1) %] > <!-- 1 => OPAC --> >@@ -337,7 +339,7 @@ > <caption>[% issues_count | html %] Item(s) checked out</caption> > <thead> > <tr> >- [% IF ( JacketImages ) %]<th class="no-sort"> </th>[% END %] >+ [% IF ( JacketImages || CoverImagePlugins ) %]<th class="no-sort"> </th>[% END %] > <th class="all anti-the">Title</th> > <th>Author</th> > <th>Checked out on</th> >@@ -368,7 +370,7 @@ > <tbody> > [% FOREACH ISSUE IN ISSUES %] > <tr [% IF ISSUE.overdue %]class="overdue"[% END %]> >- [% IF ( JacketImages ) %] >+ [% IF ( JacketImages || CoverImagePlugins ) %] > <td class="jacketcell"> > [% IF ( OPACAmazonCoverImages ) %] > [% IF ( ISSUE.normalized_isbn ) %] >@@ -729,7 +731,7 @@ > <!-- OVERDUES TABLE ROWS --> > <thead> > <tr> >- [% IF ( JacketImages ) %]<th class="no-sort"> </th>[% END %] >+ [% IF ( JacketImages || CoverImagePlugins ) %]<th class="no-sort"> </th>[% END %] > <th class="all anti-the">Title</th> > [% UNLESS ( item_level_itypes ) %]<th>Item type</th>[% END %] > [% IF ( show_barcode ) %]<th>Barcode</th>[% END %] >@@ -748,7 +750,7 @@ > <tbody> > [% FOREACH OVERDUE IN OVERDUES %] > <tr> >- [% IF ( JacketImages ) %] >+ [% IF ( JacketImages || CoverImagePlugins ) %] > <td class="jacketcell"> > [% IF ( OPACAmazonCoverImages ) %] > [% IF ( OVERDUE.normalized_isbn ) %] >@@ -1079,6 +1081,7 @@ > [% Asset.js("js/form-submit.js") | $raw %] > [% INCLUDE 'calendar.inc' %] > [% INCLUDE 'datatables.inc' %] >+ [% CoverImagePlugins | $raw %] > <script> > var AR_CAPTION_COUNT = _("(%s total)"); > >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36154
:
163744
|
168157
|
168158
|
168925
|
170295
|
170296
|
170297
|
173593
|
173594
|
173595
|
175490
|
175491
|
175492
|
179892
|
179893
|
179894
|
181290
| 181291 |
181292