Bugzilla – Attachment 181309 Details for
Bug 39700
Fix test case t/db_dependent/Authority/Merge.t broken in 34739
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39700: Fix test case t/db_dependent/Authority/Merge.t broken in 34739
Bug-39700-Fix-test-case-tdbdependentAuthorityMerge.patch (text/plain), 2.18 KB, created by
Thomas Klausner
on 2025-04-22 19:32:56 UTC
(
hide
)
Description:
Bug 39700: Fix test case t/db_dependent/Authority/Merge.t broken in 34739
Filename:
MIME Type:
Creator:
Thomas Klausner
Created:
2025-04-22 19:32:56 UTC
Size:
2.18 KB
patch
obsolete
>From dbc12a663978e7d3a4811d7989a0435d563b7361 Mon Sep 17 00:00:00 2001 >From: Thomas Klausner <domm@plix.at> >Date: Tue, 22 Apr 2025 19:25:46 +0000 >Subject: [PATCH] Bug 39700: Fix test case t/db_dependent/Authority/Merge.t > broken in 34739 > >Bug 34739 added some test cases to t/db_dependent/Authority/Merge.t which work when run as a standlone test, but fail when run with some other tests. This patch fixes the test. > >Test Plan: > >* Start KTD and enter a shell >* Run only the single test: > prove t/db_dependent/Authority/Merge.t >* You should get "All test successful" >* Now run two tests: > prove t/db_dependent/Biblio.t t/db_dependent/Authority/Merge.t >* You will get a FAIL: > t/db_dependent/Authority/Merge.t (Wstat: 256 (exited 1) Tests: 14 Failed: 1) > Failed test: 13 > >* Apply the patch > >* Again run two tests: > prove t/db_dependent/Biblio.t t/db_dependent/Authority/Merge.t >* You should get "All test successful" > >Sponsored by: HKS3 >--- > t/db_dependent/Authority/Merge.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Authority/Merge.t b/t/db_dependent/Authority/Merge.t >index 15ede67477..885e7fdaaf 100755 >--- a/t/db_dependent/Authority/Merge.t >+++ b/t/db_dependent/Authority/Merge.t >@@ -697,7 +697,7 @@ subtest 'ModBiblio calls from merge' => sub { > my $biblio_record = MARC::Record->new(); > $biblio_record->insert_fields_ordered( > MARC::Field->new( '609', '1', '1', a => 'Brown,', 'c' => 'Father', 9 => $authid ) ); >- my $biblionumber = AddBiblio( $biblio_record, '', { skip_record_index => 1 } ); >+ my ($biblionumber) = AddBiblio( $biblio_record, '', { skip_record_index => 1 } ); > > my $biblio_module = Test::MockModule->new('C4::AuthoritiesMarc'); > $biblio_module->mock( >@@ -748,7 +748,7 @@ subtest 'ModBiblio calls from merge' => sub { > my $biblio_record2 = MARC::Record->new(); > $biblio_record2->insert_fields_ordered( > MARC::Field->new( '109', '1', ' ', a => 'Chesterton, G.K.', 9 => $authid2 ) ); >- my $biblionumber2 = AddBiblio( $biblio_record2, '', { skip_record_index => 1 } ); >+ my ($biblionumber2) = AddBiblio( $biblio_record2, '', { skip_record_index => 1 } ); > > my $num_biblio_edited; > warnings_are { >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39700
:
181309
|
181310