Bugzilla – Attachment 181312 Details for
Bug 39584
Booking post-processing time cuts into circulation period
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39584: Use startDate instead of hoverDate when calculating loan period on mouseover
Bug-39584-Use-startDate-instead-of-hoverDate-when-.patch (text/plain), 1.91 KB, created by
Lucas Gass (lukeg)
on 2025-04-22 20:32:57 UTC
(
hide
)
Description:
Bug 39584: Use startDate instead of hoverDate when calculating loan period on mouseover
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2025-04-22 20:32:57 UTC
Size:
1.91 KB
patch
obsolete
>From 7f02741807203563138728ab8d347aa41c902dbf Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Tue, 22 Apr 2025 20:30:59 +0000 >Subject: [PATCH] Bug 39584: Use startDate instead of hoverDate when > calculating loan period on mouseover > >To test: >1. Set up two days of post-processing time in the circ rules for an item type. >2. Make that item type bookable. >3. Place a booking for an item from that item type. Note that the 2-days of post-processing time are factored into the total number of days allowed for the booking. For a 7-day circ period, the booking cannot be set for 7 days; it is enforced to end at 5. >4. APPLY PATCH >5. Try the booking again, this time you should be able to select the full loan period for that item. >--- > koha-tmpl/intranet-tmpl/prog/js/modals/place_booking.js | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/modals/place_booking.js b/koha-tmpl/intranet-tmpl/prog/js/modals/place_booking.js >index 84330c3960b..7c6f4a0ffc7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/modals/place_booking.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/modals/place_booking.js >@@ -931,8 +931,10 @@ $("#placeBookingModal").on("show.bs.modal", function (e) { > ? startDate.subtract(leadDays, "day") > : hoverDate.subtract(leadDays, "day"); > const leadEnd = startDate ? startDate : hoverDate; >- const trailStart = hoverDate; >- const trailEnd = hoverDate.add(trailDays, "day"); >+ const trailStart = startDate; >+ const trailEnd = startDate >+ ? startDate.add(trailDays, "day") >+ : null; > > let leadDisable = false; > let trailDisable = false; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39584
:
181312
|
181394
|
182448
|
182451