Bugzilla – Attachment 18144 Details for
Bug 10120
Fine recalculation on return needs to be a system preference
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 10120 : Adding a syspref to control if overdue charges are updated /on return
PASSED-QA-Bug-10120--Adding-a-syspref-to-control-i.patch (text/plain), 5.03 KB, created by
Katrin Fischer
on 2013-05-15 06:30:18 UTC
(
hide
)
Description:
[PASSED QA] Bug 10120 : Adding a syspref to control if overdue charges are updated /on return
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-05-15 06:30:18 UTC
Size:
5.03 KB
patch
obsolete
>From 6b38d5ab95c4178676f1189854acc0d09cf924c9 Mon Sep 17 00:00:00 2001 >From: Chris Cormack <chris@bigballofwax.co.nz> >Date: Tue, 30 Apr 2013 08:56:22 +1200 >Subject: [PATCH] [PASSED QA] Bug 10120 : Adding a syspref to control if > overdue charges are updated /on return > >On by default, >To Test > >1/ Create an overdue item, that should get fines >2/ Return the item >3/ Check the borrowers record to see if the fine has been added/updated > >Apply patch >1/ Make sure preference is set to do >Repeat steps 1-3 above > >2/ Switch the preference to don't >Repeat stes 1-2 >3/ Check the fine hasn't been added/updated > >Signed-off-by: David Cook <dcook@prosentient.com.au> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >All tests and QA script pass, works as described. >I would categorize this a bug fix for libraries that don't want >the new changed behaviour that was introduced by recalculating >fines on return. >--- > C4/Circulation.pm | 4 +++- > installer/data/mysql/sysprefs.sql | 1 + > installer/data/mysql/updatedatabase.pl | 15 +++++++++++++++ > .../en/modules/admin/preferences/circulation.pref | 7 +++++++ > 4 files changed, 26 insertions(+), 1 deletion(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 1de40e8..e069132 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -1785,7 +1785,9 @@ sub AddReturn { > } > > if ($borrowernumber) { >- if($issue->{'overdue'}){ >+ if( C4::Context->preference('CalculateFinesOnReturn') && $issue->{'overdue'}){ >+ # we only need to calculate and change the fines if we want to do that on return >+ # Should be on for hourly loans > my ( $amount, $type, $unitcounttotal ) = C4::Overdues::CalcFine( $item, $borrower->{categorycode},$branch, $datedue, $today ); > $type ||= q{}; > if ( $amount > 0 && ( C4::Context->preference('finesMode') eq 'production' )) { >diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql >index 8576d5d..8ca833f 100644 >--- a/installer/data/mysql/sysprefs.sql >+++ b/installer/data/mysql/sysprefs.sql >@@ -424,3 +424,4 @@ INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES(' > INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES ('HighlightOwnItemsOnOPAC','0','','If on, and a patron is logged into the OPAC, items from his or her home library will be emphasized and shown first in search results and item details.','YesNo'); > INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES ('HighlightOwnItemsOnOPACWhich','PatronBranch','PatronBranch|OpacURLBranch','Decides which branch''s items to emphasize. If PatronBranch, emphasize the logged in user''s library''s items. If OpacURLBranch, highlight the items of the Apache var BRANCHCODE defined in Koha''s Apache configuration file.','Choice'); > INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('UniqueItemFields', 'barcode', 'Space-separated list of fields that should be unique (used in acquisition module for item creation). Fields must be valid SQL column names of items table', '', 'Free'); >+INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES ('CalculateFinesOnReturn','1','Switch to control if overdue fines are calculated on return or not', '', 'YesNo'); >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index 35f575a..23af027 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -6834,6 +6834,21 @@ if (C4::Context->preference("Version") < TransformToNum($DBversion)) { > SetVersion($DBversion); > } > >+ >+$DBversion = "XXX"; >+if ( CheckVersion($DBversion) ) { >+ $dbh->do( >+ q{ >+INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES ('CalculateFinesOnReturn','1','Switch to control if overdue fines are calculated on return or not', '', 'YesNo'); >+} >+ ); >+ print >+"Upgrade to $DBversion done (Bug 10120 - Fines on item return controlled by a systempreference)\n"; >+ SetVersion($DBversion); >+} >+ >+ >+ > =head1 FUNCTIONS > > =head2 TableExists($table) >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >index f88d964..d24be41 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >@@ -319,6 +319,13 @@ Circulation: > yes: Block > no: "Don't block" > - returning of items that have been withdrawn. >+ - >+ - pref: CalculateFinesOnReturn >+ choices: >+ yes: Do >+ no: "Don't" >+ - calculate and update overdue charges when an item is returned. >+ - <br /><b>NOTE If you are doing hourly loans then you should have this on.</b> > Holds Policy: > - > - pref: AllowHoldPolicyOverride >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10120
:
17824
|
17825
|
17885
|
17886
|
17887
|
18143
| 18144 |
18145
|
44078