Bugzilla – Attachment 181496 Details for
Bug 39747
Wrong system preference 'DefaultHoldExpirationUnitOfTime' in test suite
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39747: Fix wrong system preference 'DefaultHoldExpirationUnitOfTime' in test suite
Bug-39747-Fix-wrong-system-preference-DefaultHoldE.patch (text/plain), 1.38 KB, created by
Fridolin Somers
on 2025-04-25 09:37:00 UTC
(
hide
)
Description:
Bug 39747: Fix wrong system preference 'DefaultHoldExpirationUnitOfTime' in test suite
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2025-04-25 09:37:00 UTC
Size:
1.38 KB
patch
obsolete
>From d25a45619fc9ad0d9ac4ca11dba484c2bcdbb421 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Fri, 25 Apr 2025 11:35:24 +0200 >Subject: [PATCH] Bug 39747: Fix wrong system preference > 'DefaultHoldExpirationUnitOfTime' in test suite > >Correct preference is 'DefaultHoldExpirationdateUnitOfTime'. >Also no reason for ";". > >Test by running : prove t/db_dependent/Reserves.t >--- > t/db_dependent/Reserves.t | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t >index 93ab654c18..567f638cba 100755 >--- a/t/db_dependent/Reserves.t >+++ b/t/db_dependent/Reserves.t >@@ -1856,9 +1856,9 @@ subtest 'DefaultHoldExpiration tests' => sub { > plan tests => 2; > $schema->storage->txn_begin; > >- t::lib::Mocks::mock_preference( 'DefaultHoldExpirationdate', 1 ); >- t::lib::Mocks::mock_preference( 'DefaultHoldExpirationdatePeriod', 365 ); >- t::lib::Mocks::mock_preference( 'DefaultHoldExpirationUnitOfTime', 'days;' ); >+ t::lib::Mocks::mock_preference( 'DefaultHoldExpirationdate', 1 ); >+ t::lib::Mocks::mock_preference( 'DefaultHoldExpirationdatePeriod', 365 ); >+ t::lib::Mocks::mock_preference( 'DefaultHoldExpirationdateUnitOfTime', 'days' ); > > my $patron = $builder->build_object( { class => 'Koha::Patrons' } ); > my $item = $builder->build_sample_item(); >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39747
:
181496
|
181507