Bugzilla – Attachment 181501 Details for
Bug 39492
Add missing aria label on the OPAC holdings table browse shelf link
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39492: Browse Shelf Links on Publications Pg
Bug-39492-Browse-Shelf-Links-on-Publications-Pg.patch (text/plain), 2.73 KB, created by
Alexander Blanchard
on 2025-04-25 10:40:49 UTC
(
hide
)
Description:
Bug 39492: Browse Shelf Links on Publications Pg
Filename:
MIME Type:
Creator:
Alexander Blanchard
Created:
2025-04-25 10:40:49 UTC
Size:
2.73 KB
patch
obsolete
>From de7064188c906de8f7fde8e6742ad4d61682b9a6 Mon Sep 17 00:00:00 2001 >From: Alexander Blanchard <alexander.blanchard@openfifth.co.uk> >Date: Fri, 25 Apr 2025 10:27:53 +0000 >Subject: [PATCH] Bug 39492: Browse Shelf Links on Publications Pg > >An accessibility audit has highlighted that the Browse Shelf link on the Publicaitons page does not provide enough context for visually impaired users. The suggested solution was to add aria-labels to provide context. >This follow up patch addresses the missing html filter. > >To test: >1) Ensure that you have at least one item with a call number. >2) Navigate to the item's page and scroll down to the table. >3) Right click and choose inspect on the 'Browse Shelf' link and note that there is not an aria label. >4) Apply patch. >5) Repeat the steps above. >6) Notice that there is an aria-label that adds context to the Browse Shelf link by including the title of the record. >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index a87464aed5..dde870ceb6 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -1428,13 +1428,13 @@ > (<a > class="close_shelf" > href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% ITEM_RESULT.biblionumber | html %]&shelfbrowse_itemnumber=[% ITEM_RESULT.itemnumber | html %]#[% tab | html %]" >- aria-label="Browse Shelf for [% title %]" >- >Browse shelf???<span class="sr-only">(Opens below)</span></a >+ aria-label="Browse Shelf for [% title | html %]" >+ >Browse shelf<span class="sr-only">(Opens below)</span></a > >) > [% ELSE %] > (<a > href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% ITEM_RESULT.biblionumber | uri %]&shelfbrowse_itemnumber=[% ITEM_RESULT.itemnumber | uri %]#[% tab | uri %]" >- aria-label="Browse Shelf for [% title %]" >+ aria-label="Browse Shelf for [% title | html %]" > >Browse shelf<span class="sr-only">(Opens below)</span></a > >) > [% END %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39492
:
180412
|
180524
|
181501
|
181502
|
181572
|
181573
|
182414
|
182415
|
182416