Bugzilla – Attachment 181607 Details for
Bug 38441
Allow for an ILL history check workflow stage
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38441: (QA follow-up) Minor change
Bug-38441-QA-follow-up-Minor-change.patch (text/plain), 2.15 KB, created by
Pedro Amorim
on 2025-04-28 12:17:13 UTC
(
hide
)
Description:
Bug 38441: (QA follow-up) Minor change
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-04-28 12:17:13 UTC
Size:
2.15 KB
patch
obsolete
>From 59e0047fc67a61e3b33c6890d4dfe7620a656265 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Thu, 17 Apr 2025 15:14:30 -0300 >Subject: [PATCH] Bug 38441: (QA follow-up) Minor change > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > installer/data/mysql/atomicupdate/bug_38441.pl | 2 +- > t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t | 8 +++----- > 2 files changed, 4 insertions(+), 6 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_38441.pl b/installer/data/mysql/atomicupdate/bug_38441.pl >index 9a584ebc3d1..4455cf45521 100755 >--- a/installer/data/mysql/atomicupdate/bug_38441.pl >+++ b/installer/data/mysql/atomicupdate/bug_38441.pl >@@ -19,6 +19,6 @@ return { > ); > } > ); >- say $out "Added new system preference 'ILLHistoryCheck'"; >+ say_success( $out, "Added new system preference 'ILLHistoryCheck'" ); > }, > }; >diff --git a/t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t b/t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t >index 873ea4c30b1..86f0f2065ac 100755 >--- a/t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t >+++ b/t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t >@@ -28,7 +28,8 @@ use t::lib::Mocks; > use Koha::ILL::Request::Workflow::HistoryCheck; > use Koha::Database; > >-my $schema = Koha::Database->new->schema; >+my $schema = Koha::Database->new->schema; >+my $builder = t::lib::TestBuilder->new; > > my $isbn = '321321321'; > >@@ -38,8 +39,6 @@ subtest 'show_history_check' => sub { > > $schema->storage->txn_begin; > >- my $builder = t::lib::TestBuilder->new; >- > use_ok('Koha::ILL::Request::Workflow::HistoryCheck'); > > my $fake_cardnumber = '123456789'; >@@ -122,8 +121,6 @@ subtest 'after_request_created' => sub { > > $schema->storage->txn_begin; > >- my $builder = t::lib::TestBuilder->new; >- > my $fake_cardnumber = '123456789'; > my $metadata = { > title => 'This is a title', >@@ -187,6 +184,7 @@ subtest 'after_request_created' => sub { > 'Contains staffnotes related submissions by self patron' > ); > >+ $schema->storage->txn_rollback; > }; > > 1; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38441
:
174604
|
174605
|
174606
|
174607
|
174608
|
174609
|
174610
|
174611
|
175300
|
175301
|
175302
|
175303
|
175304
|
175305
|
175306
|
175307
|
176507
|
176508
|
176509
|
176510
|
176511
|
176512
|
176513
|
176514
|
176561
|
176566
|
176573
|
176829
|
179800
|
179801
|
179802
|
179803
|
179804
|
179805
|
179806
|
179807
|
179808
|
179809
|
179810
|
179811
|
180034
|
180035
|
180036
|
180037
|
180038
|
180039
|
180040
|
180041
|
180042
|
180043
|
180044
|
180045
|
180907
|
180908
|
180909
|
180910
|
180911
|
180912
|
180913
|
180914
|
180915
|
180916
|
180917
|
180918
|
180919
|
181072
|
181111
|
181112
|
181113
|
181114
|
181115
|
181116
|
181117
|
181118
|
181119
|
181120
|
181121
|
181122
|
181123
|
181124
|
181125
|
181126
|
181593
|
181594
|
181595
|
181596
|
181597
|
181598
|
181599
|
181600
|
181601
|
181602
|
181603
|
181604
|
181605
|
181606
| 181607