Bugzilla – Attachment 181634 Details for
Bug 39765
Old-fashioned ILL backends (not plugins) are not working
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39765: Revert plugin check logic
Bug-39765-Revert-plugin-check-logic.patch (text/plain), 1.15 KB, created by
Tomás Cohen Arazi (tcohen)
on 2025-04-28 17:45:22 UTC
(
hide
)
Description:
Bug 39765: Revert plugin check logic
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2025-04-28 17:45:22 UTC
Size:
1.15 KB
patch
obsolete
>From 02b4a9da8543771b6c5e58ec687076b07c96f929 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Mon, 28 Apr 2025 15:02:50 +0000 >Subject: [PATCH] Bug 39765: Revert plugin check logic > >Apply patch. Run tests. >prove t/db_dependent/Koha/ILL/Requests.t >--- > Koha/ILL/Request.pm | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > >diff --git a/Koha/ILL/Request.pm b/Koha/ILL/Request.pm >index 87afa890fa5..1c9473ebdab 100644 >--- a/Koha/ILL/Request.pm >+++ b/Koha/ILL/Request.pm >@@ -1166,19 +1166,15 @@ sub expand_template { > $params->{opac_template} = $template_name; > > } else { >- my $plugin = >- $self->{_plugin} >- ? $self->{_plugin} >- : $self->get_plugin( $self->_backend->name ); > > # Generate path to file to load > my $backend_dir; > my $backend_tmpl; > >- if ($plugin) { >+ if ( $self->{_plugin} ) { > > # New way of loading backends: Through plugins >- $backend_dir = $plugin->bundle_path; >+ $backend_dir = $self->{_plugin}->bundle_path; > $backend_tmpl = $backend_dir; > > } else { >-- >2.49.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39765
:
181623
|
181633
|
181634
|
181635
|
181638