Bugzilla – Attachment 181644 Details for
Bug 39771
The `data` attribute in job.yaml should be nullable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39771: Make `data` attribute nullable for jobs
Bug-39771-Make-data-attribute-nullable-for-jobs.patch (text/plain), 1.38 KB, created by
HKS3 Tadeusz Sośnierz
on 2025-04-29 11:11:38 UTC
(
hide
)
Description:
Bug 39771: Make `data` attribute nullable for jobs
Filename:
MIME Type:
Creator:
HKS3 Tadeusz Sośnierz
Created:
2025-04-29 11:11:38 UTC
Size:
1.38 KB
patch
obsolete
>From 3feb2907cd9d0b8e6831f30e606fdaacdb831f93 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Tue, 29 Apr 2025 07:52:41 -0300 >Subject: [PATCH] Bug 39771: Make `data` attribute nullable for jobs >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This patch makes the `data` attribute nullable. This happens when >`$job->finish()` is called with no parameters. > >To test: >1. Apply the regression tests patch >2. Run: > $ ktd --shell > k$ prove t/db_dependent/api/v1/jobs.t >=> FAIL: Tests don't pass, a 500 is returned when `finish()` was called >with no data >3. Apply this patch >4. Rebuild the API spec: > k$ yarn api:bundle >5. Repeat 2 >=> SUCCESS: Tests pass! The API doesn't explode >6. Sign off :-D > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >Signed-off-by: Tadeusz âtadzikâ SoÅnierz <tadeusz@sosnierz.com> >--- > api/v1/swagger/definitions/job.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/api/v1/swagger/definitions/job.yaml b/api/v1/swagger/definitions/job.yaml >index 966e3a3ef8..7bac1f137f 100644 >--- a/api/v1/swagger/definitions/job.yaml >+++ b/api/v1/swagger/definitions/job.yaml >@@ -31,7 +31,9 @@ properties: > type: string > data: > description: job data >- type: object >+ type: >+ - object >+ - "null" > context: > description: job context > type: object >-- >2.47.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39771
:
181641
|
181642
|
181643
|
181644
|
182079
|
182080