Bugzilla – Attachment 181656 Details for
Bug 39752
Koha MarcOrder does not verify bibliographic record exists when adding order and items
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39752: (QA follow-up) Unit test
Bug-39752-QA-follow-up-Unit-test.patch (text/plain), 2.44 KB, created by
Nick Clemens (kidclamp)
on 2025-04-29 13:20:11 UTC
(
hide
)
Description:
Bug 39752: (QA follow-up) Unit test
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2025-04-29 13:20:11 UTC
Size:
2.44 KB
patch
obsolete
>From 19f64765b689ba2dc3debcd3788a67afc855a4e0 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 29 Apr 2025 13:13:27 +0000 >Subject: [PATCH] Bug 39752: (QA follow-up) Unit test > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > t/db_dependent/Koha/MarcOrder.t | 35 ++++++++++++++++++++++++++++++++- > 1 file changed, 34 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/MarcOrder.t b/t/db_dependent/Koha/MarcOrder.t >index 58123c7e8b6..a299e954cb3 100755 >--- a/t/db_dependent/Koha/MarcOrder.t >+++ b/t/db_dependent/Koha/MarcOrder.t >@@ -175,7 +175,7 @@ budget_code: 975$h' > }; > > subtest 'add_biblio_from_import_record()' => sub { >- plan tests => 4; >+ plan tests => 5; > > $schema->storage->txn_begin; > >@@ -221,6 +221,39 @@ subtest 'add_biblio_from_import_record()' => sub { > 'A new biblionumber is added or an existing biblionumber is returned' > ); > >+ my $match_biblio = $builder->build_sample_biblio(); >+ my $match_biblio_id = $match_biblio->biblionumber; >+ $match_biblio->delete; >+ my $match_record = MARC::Record->new(); >+ $match_record->add_fields( >+ [ '001', '1234' ], >+ [ '020', ' ', ' ', a => '9780596004931' ], >+ [ '975', ' ', ' ', p => 10, q => 1, h => 1 ], >+ ); >+ >+ my $match_import_record_id = C4::ImportBatch::AddBiblioToBatch( $import_batch_id, 0, $match_record, 'utf8', 0 ); >+ my $match_import_record = Koha::Import::Records->find($match_import_record_id); >+ my $import_record_match = Koha::Import::Record::Match->new( >+ { >+ import_record_id => $match_import_record_id, >+ candidate_match_id => $match_biblio_id, >+ chosen => 1, >+ } >+ )->store; >+ my $match_result = Koha::MarcOrder::add_biblio_from_import_record( >+ { >+ import_record => $match_import_record, >+ matcher_id => $sample_import_batch->{matcher_id}, >+ overlay_action => 'replace', >+ agent => 'interface', >+ import_batch_id => $import_batch_id >+ } >+ ); >+ isnt( >+ $match_result->{record_result}->{biblionumber}, $match_biblio_id, >+ 'A new biblionumber is added when the matched biblionumber does not exist' >+ ); >+ > # Check that records are skipped if not selected when called from addorderiso2709.pl > # Pass in an empty array and the record should be skipped > my @import_record_id_selected = (); >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39752
:
181576
|
181639
| 181656 |
181657