Bugzilla – Attachment 181674 Details for
Bug 39777
ILL History Check does not show in OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39777: Use cardnumber OR authenticated user cardnumber
Bug-39777-Use-cardnumber-OR-authenticated-user-car.patch (text/plain), 1.57 KB, created by
Pedro Amorim
on 2025-04-29 15:43:30 UTC
(
hide
)
Description:
Bug 39777: Use cardnumber OR authenticated user cardnumber
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-04-29 15:43:30 UTC
Size:
1.57 KB
patch
obsolete
>From ca0037a8c511040574807ebe75f55f55ebd12c0d Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Tue, 29 Apr 2025 15:37:19 +0000 >Subject: [PATCH] Bug 39777: Use cardnumber OR authenticated user cardnumber > >Test plan: >1) Apply the 'rollback tests' patch to reinstate the testing of the behavior if a cardnumber is missing (and a user is authenticated) >2) Run tests (they should fail): > prove t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t >3) Apply this patch. Repeat 2) They should pass. > >Test plan for UI: >1) Enable ILLModule and ILLHistoryCheck >2) Create a new ILL on OPAC, visit: >http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard >3) Select type="journal", enter DOI = "123". Create. >4) Repeat steps 2 and 3. A history check screen should be displayed (it is not, before this patch). >--- > Koha/ILL/Request/Workflow/HistoryCheck.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/Koha/ILL/Request/Workflow/HistoryCheck.pm b/Koha/ILL/Request/Workflow/HistoryCheck.pm >index 818f2f4c742..b8f7fb55d14 100644 >--- a/Koha/ILL/Request/Workflow/HistoryCheck.pm >+++ b/Koha/ILL/Request/Workflow/HistoryCheck.pm >@@ -193,7 +193,8 @@ sub _find_matching_requests { > @existing_id_fields = grep { $_ eq 'pubmedid' } @existing_id_fields; > } > >- my $patron = Koha::Patrons->find( { cardnumber => $self->{metadata}->{cardnumber} } ); >+ my $patron = Koha::Patrons->find( >+ { cardnumber => $self->{metadata}->{cardnumber} || C4::Context->userenv->{'cardnumber'} } ); > > return 0 unless $patron; > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39777
:
181671
|
181672
|
181674
|
181692
|
181693