Bugzilla – Attachment 181689 Details for
Bug 39464
Z39.50 Search results not highlighting grey rows in yellow when previewing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39464: Grey rows in tables not highlighting in yellow when they should
Bug-39464-Grey-rows-in-tables-not-highlighting-in-.patch (text/plain), 2.79 KB, created by
Lucas Gass (lukeg)
on 2025-04-29 21:20:57 UTC
(
hide
)
Description:
Bug 39464: Grey rows in tables not highlighting in yellow when they should
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2025-04-29 21:20:57 UTC
Size:
2.79 KB
patch
obsolete
>From e50563c79c82a9600b790e25df4e1714e7ba514f Mon Sep 17 00:00:00 2001 >From: Phil Ringnalda <phil@chetcolibrary.org> >Date: Sat, 12 Apr 2025 12:09:29 -0700 >Subject: [PATCH] Bug 39464: Grey rows in tables not highlighting in yellow > when they should > >Because the CSS rule for turning odd-numbered rows grey is highly-specific >(tbody tr:nth-child(2n+1):not(.dtrg-group, .active, .ok) td:not(.bg-danger, >.bg-warning, .bg-info, .bg-success, .bg-primary)), it overrides the >.highlighted-row, .highlighted-row td rule that some tables use to turn the >background of a currently-selected row yellow, so highlighted-row needs to be >added to the lists of not(). > >Test plan: > 1. Without the patch, Cataloging - New from Z39.50/SRU, perform a search like > Author smith which will return at least two results. > 2. On an even-numbered row with a white background, click MARC and note that > the row is given a yellow background (either by increasing the size of the > popup to peer around the preview, or by closing the preview, since the > highlight persists). > 3. On an odd-numbered row with a grey background, click MARC and note that > the row isn't given a yellow background > 4. Administration - Circulation and fine rules, if you don't already have at > least two rules add one by just changing the Patron category in the edit > row and Save > 5. On a row with a white background, click Edit and note that the background > for that row is yellow > 6. On a row with a grey background, click Edit and note that the background > remains grey, not yellow > 7. Apply patch, in ktd --shell yarn build (or in a sandbox Actions - Build > CSS and JS), clear browser cache or shift+Reload the page > 8. Repeat steps 1-6, but this time note that you get the same yellow > highlighted background for both odd and even rows. > >Signed-off-by: Magnus Enger <magnus@libriotech.no> >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss b/koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss >index 7927c8841da..8720f3b449c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss >@@ -410,9 +410,9 @@ caption { > > tbody { > tr { >- &:nth-child( odd ):not( .dtrg-group, .active, .ok ) { >+ &:nth-child( odd ):not( .dtrg-group, .active, .ok, .highlighted-row ) { > td { >- &:not( .bg-danger, .bg-warning, .bg-info, .bg-success, .bg-primary ) { >+ &:not( .bg-danger, .bg-warning, .bg-info, .bg-success, .bg-primary, .highlighted-row ) { > background-color: $table-odd-row; > } > } >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39464
:
180890
|
180895
|
181219
| 181689