Bugzilla – Attachment 181836 Details for
Bug 33012
Accessibility: Some navigation items in OPAC cannot be accessed by keyboard (search history, log out)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
An accessibility audit highlighted that when logged in you cannot tab to the log out link in the welcome menu. The search history link in the same menu was also unable to be tabbed to. These links were also not able to be reached using arrows.
An-accessibility-audit-highlighted-that-when-logge.patch (text/plain), 9.29 KB, created by
Alexander Blanchard
on 2025-05-01 19:38:49 UTC
(
hide
)
Description:
An accessibility audit highlighted that when logged in you cannot tab to the log out link in the welcome menu. The search history link in the same menu was also unable to be tabbed to. These links were also not able to be reached using arrows.
Filename:
MIME Type:
Creator:
Alexander Blanchard
Created:
2025-05-01 19:38:49 UTC
Size:
9.29 KB
patch
obsolete
>From ea20a4c401794c6a3af9111e264b4bd589b37a2f Mon Sep 17 00:00:00 2001 >From: Alexander Blanchard <alexander.blanchard@openfifth.co.uk> >Date: Thu, 1 May 2025 19:34:22 +0000 >Subject: [PATCH] An accessibility audit highlighted that when logged in you > cannot tab to the log out link in the welcome menu. The search history link > in the same menu was also unable to be tabbed to. These links were also not > able to be reached using arrows. > >The links for Your Lists, Private Lists and New List could be reached using the arrows on the keyboard but not via the tab option. > >To Test: >1) Navigate to Koha oPac. >2) Ensure you are logged in. >3) Use tabs to navigate the site. >4) When you reach the Welcome menu press enter. >5) Note that you can tab to 'Your Account' and the 'Clear' icon but not to 'Search History' or to 'Log Out' >6) Tab also to the hamburger menu and press enter >7) Note than you can navigate this menu via the arrows on the keyboard but not via the tab button >8) Apply patch >9) Repeat steps 1-7 >10) Note that you can now tab to all of the above links >--- > .../bootstrap/en/includes/masthead.inc | 24 +++++++++---------- > 1 file changed, 12 insertions(+), 12 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >index 9eb4e7b5d1..e31b6ac89d 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >@@ -64,43 +64,43 @@ > </a> > <div aria-labelledby="listsmenu" role="menu" class="dropdown-menu"> > [% IF some_public_shelves.count %] >- <a class="dropdown-item" href="/cgi-bin/koha/opac-shelves.pl?op=list&public=1" tabindex="-1" role="menuitem"><strong>Public lists</strong></a> >+ <a class="dropdown-item" href="/cgi-bin/koha/opac-shelves.pl?op=list&public=1" tabindex="0" role="menuitem"><strong>Public lists</strong></a> > [% SET number_of_public_shelves = 0 %] > [% FOREACH s IN some_public_shelves %] >- <a class="dropdown-item" href="/cgi-bin/koha/opac-shelves.pl?op=view&shelfnumber=[% s.shelfnumber | uri %]&sortfield=[% s.sortfield | uri %]" tabindex="-1" role="menuitem" >+ <a class="dropdown-item" href="/cgi-bin/koha/opac-shelves.pl?op=view&shelfnumber=[% s.shelfnumber | uri %]&sortfield=[% s.sortfield | uri %]" tabindex="0" role="menuitem" > >[% s.shelfname | html %]</a > > > [% SET number_of_public_shelves = number_of_public_shelves + 1 %] > [% IF number_of_public_shelves >= 10 %][% LAST %][% END %] > [% END %] > [% IF some_public_shelves.count > 10 %] >- <a class="dropdown-item listmenulink" href="/cgi-bin/koha/opac-shelves.pl?op=list&public=1" tabindex="-1" role="menuitem">View all</a> >+ <a class="dropdown-item listmenulink" href="/cgi-bin/koha/opac-shelves.pl?op=list&public=1" tabindex="0" role="menuitem">View all</a> > [% END %] > [% END %] > [% IF Koha.Preference( 'opacuserlogin' ) == 1 && some_public_shelves.count > 0 %] > <div class="dropdown-divider"></div> > [% END %] > [% IF Koha.Preference( 'opacuserlogin' ) == 1 %] >- <a class="dropdown-item" href="/cgi-bin/koha/opac-shelves.pl?op=list&public=0" tabindex="-1" role="menuitem"><strong>Your lists</strong></a> >+ <a class="dropdown-item" href="/cgi-bin/koha/opac-shelves.pl?op=list&public=0" tabindex="0" role="menuitem"><strong>Your lists</strong></a> > [% IF loggedinusername %] > [% IF some_private_shelves.count %] > [% SET number_of_private_shelves = 0 %] > [% FOREACH s IN some_private_shelves %] >- <a class="dropdown-item" href="/cgi-bin/koha/opac-shelves.pl?op=view&shelfnumber=[% s.shelfnumber | uri %]&sortfield=[% s.sortfield | uri %]" tabindex="-1" role="menuitem" >+ <a class="dropdown-item" href="/cgi-bin/koha/opac-shelves.pl?op=view&shelfnumber=[% s.shelfnumber | uri %]&sortfield=[% s.sortfield | uri %]" tabindex="0" role="menuitem" > >[% s.shelfname | html %]</a > > > [% SET number_of_private_shelves = number_of_private_shelves + 1 %] > [% IF number_of_private_shelves >= 10 %][% LAST %][% END %] > [% END %] > [% IF some_private_shelves.count > 10 %] >- <a class="dropdown-item listmenulink" href="/cgi-bin/koha/opac-shelves.pl?op=list&public=0" tabindex="-1" role="menuitem">View all</a> >+ <a class="dropdown-item listmenulink" href="/cgi-bin/koha/opac-shelves.pl?op=list&public=0" tabindex="0" role="menuitem">View all</a> > [% END %] > [% ELSE %] >- <a class="dropdown-item disabled" aria-disabled="true" href="#" tabindex="-1" role="menuitem">No private lists</a> >+ <a class="dropdown-item disabled" aria-disabled="true" href="#" tabindex="0" role="menuitem">No private lists</a> > [% END %] >- <a class="dropdown-item listmenulink" href="/cgi-bin/koha/opac-shelves.pl?op=add_form" tabindex="-1" role="menuitem">New list</a> >+ <a class="dropdown-item listmenulink" href="/cgi-bin/koha/opac-shelves.pl?op=add_form" tabindex="0" role="menuitem">New list</a> > [% ELSE %] >- <a class="dropdown-item" href="/cgi-bin/koha/opac-shelves.pl?op=add_form" tabindex="-1" role="menuitem">Log in to create your own lists</a> >+ <a class="dropdown-item" href="/cgi-bin/koha/opac-shelves.pl?op=add_form" tabindex="0" role="menuitem">Log in to create your own lists</a> > [% END # / IF loggedinusername %] > [% END # / IF opacuserlogin %] > </div> >@@ -133,7 +133,7 @@ > <i class="fa fa-user fa-icon-black fa-fw" aria-hidden="true"></i> > <span class="userlabel">Welcome, [% INCLUDE 'patron-title.inc' patron = logged_in_user no_html = 1 %]</span> > </a> >- <a tabindex="-1" role="menuitem" class="logout js-hide" href="/cgi-bin/koha/opac-main.pl?logout.x=1"><i class="fa fa-fw fa-sign-out" aria-hidden="true"></i> Log out</a> >+ <a tabindex="0" role="menuitem" class="logout js-hide" href="/cgi-bin/koha/opac-main.pl?logout.x=1"><i class="fa fa-fw fa-sign-out" aria-hidden="true"></i> Log out</a> > [% ELSE %] > [% IF Koha.Preference('casAuthentication') %] > [%# CAS authentication is too complicated for modal window %] >@@ -168,12 +168,12 @@ > </p> > [% IF Koha.Preference( 'EnableOpacSearchHistory' ) %] > <p> >- <a tabindex="-1" role="menuitem" class="login-link" href="/cgi-bin/koha/opac-search-history.pl" title="View your search history">Search history</a> >+ <a tabindex="0" role="menuitem" class="login-link" href="/cgi-bin/koha/opac-search-history.pl" title="View your search history">Search history</a> > <span class="divider-vertical"></span> > <a class="clearsh" href="/cgi-bin/koha/opac-search-history.pl?action=delete" title="Delete your search history"><i class="fa fa-trash-can" aria-hidden="true"></i> Clear</a> > </p> > [% END %] >- <a tabindex="-1" role="menuitem" class="logout" id="logout" href="/cgi-bin/koha/opac-main.pl?logout.x=1">Log out</a> >+ <a tabindex="0" role="menuitem" class="logout" id="logout" href="/cgi-bin/koha/opac-main.pl?logout.x=1">Log out</a> > </div> > </div> > [% END %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33012
:
146946
|
181509
|
181836
|
181837
|
181838
|
181839
|
181844
|
181845
|
181873