Bugzilla – Attachment 181971 Details for
Bug 39835
Tidy is_boolean / tinyint
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39835: columns_settings should be tinyint
Bug-39835-columnssettings-should-be-tinyint.patch (text/plain), 1.92 KB, created by
Jonathan Druart
on 2025-05-06 13:18:55 UTC
(
hide
)
Description:
Bug 39835: columns_settings should be tinyint
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-05-06 13:18:55 UTC
Size:
1.92 KB
patch
obsolete
>From f461d70399280f6726fb5c077160da36212a6c92 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 6 May 2025 15:18:25 +0200 >Subject: [PATCH] Bug 39835: columns_settings should be tinyint > >They are boolean in the schema file already >--- > installer/data/mysql/atomicupdate/bug_39835.pl | 9 +++++++++ > installer/data/mysql/kohastructure.sql | 4 ++-- > 2 files changed, 11 insertions(+), 2 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_39835.pl b/installer/data/mysql/atomicupdate/bug_39835.pl >index 72136c6951b..e6edc025af1 100755 >--- a/installer/data/mysql/atomicupdate/bug_39835.pl >+++ b/installer/data/mysql/atomicupdate/bug_39835.pl >@@ -32,5 +32,14 @@ return { > MODIFY COLUMN `debarred3` tinyint(1) DEFAULT 0 COMMENT 'is the patron restricted when the third notice is sent (1 for yes, 0 for no)' > } > ); >+ >+ $dbh->do( >+ q{ >+ ALTER TABLE `columns_settings` >+ MODIFY COLUMN `cannot_be_toggled` tinyint(1) NOT NULL DEFAULT 0, >+ MODIFY COLUMN `is_hidden` tinyint(1) NOT NULL DEFAULT 0 >+ } >+ ); >+ > }, > }; >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index 5cde8aea47c..de377f0d18a 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -2206,8 +2206,8 @@ CREATE TABLE `columns_settings` ( > `page` varchar(255) NOT NULL, > `tablename` varchar(255) NOT NULL, > `columnname` varchar(255) NOT NULL, >- `cannot_be_toggled` int(1) NOT NULL DEFAULT 0, >- `is_hidden` int(1) NOT NULL DEFAULT 0, >+ `cannot_be_toggled` tinyint(1) NOT NULL DEFAULT 0, >+ `is_hidden` tinyint(1) NOT NULL DEFAULT 0, > PRIMARY KEY (`module`(191),`page`(191),`tablename`(191),`columnname`(191)) > ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci; > /*!40101 SET character_set_client = @saved_cs_client */; >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39835
:
181924
|
181925
|
181926
|
181927
| 181971 |
182015
|
182020
|
182021