Bugzilla – Attachment 181985 Details for
Bug 25787
Club holds can't be placed without modify_holds_priority permission
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25787: Update club holds to only require place_holds permission
Bug-25787-Update-club-holds-to-only-require-placeh.patch (text/plain), 1.29 KB, created by
Pedro Amorim
on 2025-05-06 15:42:18 UTC
(
hide
)
Description:
Bug 25787: Update club holds to only require place_holds permission
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-05-06 15:42:18 UTC
Size:
1.29 KB
patch
obsolete
>From b79ad1c30f64daf750ed897cabe7d5205826e1f9 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Sun, 23 Mar 2025 17:27:17 +0000 >Subject: [PATCH] Bug 25787: Update club holds to only require place_holds > permission > >This moves the permission check from top level to the specific place_hold >permission > >To test: > 1 - Create a club > 2 - Enroll some patrons > 3 - Find or create a staff user with 'place_holds' permission and catalogue permission > 4 - Log in as that staff > 5 - Find a book and go to holds tab' > 6 - Search for your club > 7 - Try to place hold > 8 - Nothing happens FIXME we should alert of the 403 error or other > 9 - Apply patch, yanr build, restart_all >10 - Place hold >11 - Success! > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> >--- > api/v1/swagger/paths/clubs.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/api/v1/swagger/paths/clubs.yaml b/api/v1/swagger/paths/clubs.yaml >index 9d04355ee28..c040e531f2d 100644 >--- a/api/v1/swagger/paths/clubs.yaml >+++ b/api/v1/swagger/paths/clubs.yaml >@@ -93,4 +93,4 @@ > $ref: "../swagger.yaml#/definitions/error" > x-koha-authorization: > permissions: >- reserveforothers: "1" >+ reserveforothers: place_holds >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25787
:
179633
|
181831
|
181841
|
181842
| 181985 |
181986