Bugzilla – Attachment 182021 Details for
Bug 39835
Tidy is_boolean / tinyint
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39835: Adjust some boolean flags
Bug-39835-Adjust-some-boolean-flags.patch (text/plain), 4.55 KB, created by
Jonathan Druart
on 2025-05-07 12:09:47 UTC
(
hide
)
Description:
Bug 39835: Adjust some boolean flags
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-05-07 12:09:47 UTC
Size:
4.55 KB
patch
obsolete
>From 0f7ea7c19d595f2d46aa5c31eda0936863f6208b Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 7 May 2025 13:48:59 +0200 >Subject: [PATCH] Bug 39835: Adjust some boolean flags > >--- > Koha/Schema/Result/AuthSubfieldStructure.pm | 4 ++-- > Koha/Schema/Result/Deleteditem.pm | 12 ++++++------ > Koha/Schema/Result/Item.pm | 12 ++++++------ > Koha/Schema/Result/MarcSubfieldStructure.pm | 4 ++-- > Koha/Schema/Result/Rating.pm | 2 +- > 5 files changed, 17 insertions(+), 17 deletions(-) > >diff --git a/Koha/Schema/Result/AuthSubfieldStructure.pm b/Koha/Schema/Result/AuthSubfieldStructure.pm >index 0dd90736f43..599e917e51d 100644 >--- a/Koha/Schema/Result/AuthSubfieldStructure.pm >+++ b/Koha/Schema/Result/AuthSubfieldStructure.pm >@@ -222,8 +222,8 @@ __PACKAGE__->belongs_to( > > __PACKAGE__->add_columns( > '+isurl' => { is_boolean => 1 }, >- '+linkid' => { is_boolean => 1 }, >- '+tab' => { is_boolean => 1 }, >+ '+linkid' => { is_boolean => 0 }, >+ '+tab' => { is_boolean => 0 }, > ); > > =head2 koha_object_class >diff --git a/Koha/Schema/Result/Deleteditem.pm b/Koha/Schema/Result/Deleteditem.pm >index ae17dc6d48d..778432f2723 100644 >--- a/Koha/Schema/Result/Deleteditem.pm >+++ b/Koha/Schema/Result/Deleteditem.pm >@@ -536,13 +536,13 @@ __PACKAGE__->set_primary_key("itemnumber"); > > __PACKAGE__->add_columns( > '+bookable' => { is_boolean => 1 }, >- '+damaged' => { is_boolean => 1 }, >+ '+damaged' => { is_boolean => 0 }, > '+exclude_from_local_holds_priority' => { is_boolean => 1 }, >- '+itemlost' => { is_boolean => 1 }, >- '+notforloan' => { is_boolean => 1 }, >- '+restricted' => { is_boolean => 1 }, >- '+stack' => { is_boolean => 1 }, >- '+withdrawn' => { is_boolean => 1 }, >+ '+itemlost' => { is_boolean => 0 }, >+ '+notforloan' => { is_boolean => 0 }, >+ '+restricted' => { is_boolean => 0 }, >+ '+stack' => { is_boolean => 0 }, >+ '+withdrawn' => { is_boolean => 0 }, > ); > > =head2 koha_objects_class >diff --git a/Koha/Schema/Result/Item.pm b/Koha/Schema/Result/Item.pm >index ce70d79dcb5..83b361a1400 100644 >--- a/Koha/Schema/Result/Item.pm >+++ b/Koha/Schema/Result/Item.pm >@@ -1029,13 +1029,13 @@ __PACKAGE__->belongs_to( > > __PACKAGE__->add_columns( > '+bookable' => { is_boolean => 1 }, >- '+damaged' => { is_boolean => 1 }, >+ '+damaged' => { is_boolean => 0 }, > '+exclude_from_local_holds_priority' => { is_boolean => 1 }, >- '+itemlost' => { is_boolean => 1 }, >- '+notforloan' => { is_boolean => 1 }, >- '+restricted' => { is_boolean => 1 }, >- '+stack' => { is_boolean => 1 }, >- '+withdrawn' => { is_boolean => 1 }, >+ '+itemlost' => { is_boolean => 0 }, >+ '+notforloan' => { is_boolean => 0 }, >+ '+restricted' => { is_boolean => 0 }, >+ '+stack' => { is_boolean => 0 }, >+ '+withdrawn' => { is_boolean => 0 }, > ); > > # Relationship with orders via the aqorders_item table that not have foreign keys >diff --git a/Koha/Schema/Result/MarcSubfieldStructure.pm b/Koha/Schema/Result/MarcSubfieldStructure.pm >index 0bb7ff632ff..c125a3415e9 100644 >--- a/Koha/Schema/Result/MarcSubfieldStructure.pm >+++ b/Koha/Schema/Result/MarcSubfieldStructure.pm >@@ -234,9 +234,9 @@ __PACKAGE__->belongs_to( > # DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:KVbDXEVf96eDkbPYpcmQVA > > __PACKAGE__->add_columns( >- '+hidden' => { is_boolean => 1 }, >+ '+hidden' => { is_boolean => 0 }, > '+isurl' => { is_boolean => 1 }, >- '+tab' => { is_boolean => 1 }, >+ '+tab' => { is_boolean => 0 }, > ); > > 1; >diff --git a/Koha/Schema/Result/Rating.pm b/Koha/Schema/Result/Rating.pm >index 78ae27d8b27..5a8d46cfaf3 100644 >--- a/Koha/Schema/Result/Rating.pm >+++ b/Koha/Schema/Result/Rating.pm >@@ -122,7 +122,7 @@ __PACKAGE__->belongs_to( > # DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:wUwI/h1WR8kVGMNCrv/tUQ > > __PACKAGE__->add_columns( >- '+rating_value' => { is_boolean => 1 }, >+ '+rating_value' => { is_boolean => 0 }, > ); > > 1; >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39835
:
181924
|
181925
|
181926
|
181927
|
181971
|
182015
|
182020
| 182021