Bugzilla – Attachment 182064 Details for
Bug 38356
CheckPrevCheckout should also check current loans
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
(follow-up) Bug 38356: Fix failing Circulation.t tests
0001-follow-up-Bug-38356-Fix-failing-Circulation.t-tests.patch (text/plain), 1.64 KB, created by
Emmi Takkinen
on 2025-05-08 08:45:09 UTC
(
hide
)
Description:
(follow-up) Bug 38356: Fix failing Circulation.t tests
Filename:
MIME Type:
Creator:
Emmi Takkinen
Created:
2025-05-08 08:45:09 UTC
Size:
1.64 KB
patch
obsolete
>From 5b9fd81d9b70d7e004d0a186e39ebcd38163e2dc Mon Sep 17 00:00:00 2001 >From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> >Date: Thu, 8 May 2025 11:27:13 +0300 >Subject: [PATCH] (follow-up) Bug 38356: Fix failing Circulation.t tests > >After pushing bug 38356 to main, Circulation.t tests >started to fail. Fail happened randomly and was related >to sub is_serial trying to fetch biblios metadata. This >patch changes the way test item is build in >"CanBookBeIssued + needsconfirmation message" tests. It >seems more reliable to use build_sample_item rather than >building item using biblio and biblioitem data. > >To test prove t/db_dependent/Circulation.t. >--- > t/db_dependent/Circulation.t | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index 510452c613..bd49394deb 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -7051,12 +7051,7 @@ subtest "CanBookBeIssued + needsconfirmation message" => sub { > > my $patron = $builder->build_object( { class => 'Koha::Patrons' } ); > my $library = $builder->build_object( { class => 'Koha::Libraries' } ); >- my $biblio = $builder->build_object( { class => 'Koha::Biblios' } ); >- my $biblioitem = >- $builder->build_object( { class => 'Koha::Biblioitems', value => { biblionumber => $biblio->biblionumber } } ); >- my $item = $builder->build_object( >- { class => 'Koha::Items', value => { itype => $itemtype, biblionumber => $biblio->biblionumber } } ); >- >+ my $item = $builder->build_sample_item; > my $hold = $builder->build_object( > { > class => 'Koha::Holds', >-- >2.34.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38356
:
180239
|
180305
|
181883
|
181884
|
182064
|
182065
|
182066