Bugzilla – Attachment 182072 Details for
Bug 39623
"make install" re-runs "make" process unnecessarily
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39623: Remove "install" target's dependency on "all" target
Bug-39623-Remove-install-targets-dependency-on-all.patch (text/plain), 2.42 KB, created by
Martin Renvoize (ashimema)
on 2025-05-08 12:12:16 UTC
(
hide
)
Description:
Bug 39623: Remove "install" target's dependency on "all" target
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-05-08 12:12:16 UTC
Size:
2.42 KB
patch
obsolete
>From f37c9eb5d92310b226bca1e388fd13ce82d0eb1e Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Mon, 14 Apr 2025 07:07:37 +0000 >Subject: [PATCH] Bug 39623: Remove "install" target's dependency on "all" > target > >This change removes the install target's dependency on "all". There >is no clear reason why "install" would need to depend on all other >build targets. > >After you remove this dependency, running "make" and "make install" >work the way you'd expect them to work. "make" does the build and >"make install" does the install. > >Test plan: >0. DO NOT APPLY THE PATCH YET! >1. Setup intall target >sudo mkdir /opt/koha >sudo chown kohadev-koha /opt/koha >2. Clean build env >rm -rf blib Makefile /opt/koha/* >3. perl Makefile.PL >Installation mode (dev, single, standard) [standard] single >Please specify the directory in which to install Koha [/var/lib/koha/kohadev/koha] /opt/koha >NOTE: Otherwise accept all defaults >4. make >NOTE: build-resources.PL is run and the blib directory is populated >5. make install >NOTE: build-resources.PL is run and the blib directory is populated and the built >files are installed to /opt/koha > >6. Apply the patch now >7. mv /opt/koha /opt/koha.bak >8. Re-setup install target >sudo mkdir /opt/koha >sudo chown kohadev-koha /opt/koha >9. Clean build env >rm -rf blib Makefile /opt/koha/* >10. perl Makefile.PL >Installation mode (dev, single, standard) [standard] single >Please specify the directory in which to install Koha [/var/lib/koha/kohadev/koha] /opt/koha >NOTE: Otherwise accept all defaults >11. make >NOTE: build-resources.PL is run and the blib directory is populated >12. make install >NOTE: Only the install step is run > >13. diff -r /opt/koha /opt/koha.bak >14. Note that there are no differences between the two directories > >Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> >Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> >--- > Makefile.PL | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Makefile.PL b/Makefile.PL >index 879907e36af..c1167a221aa 100644 >--- a/Makefile.PL >+++ b/Makefile.PL >@@ -1768,7 +1768,7 @@ KOHA_DEST_$key = $target_directories->{$key} > ) unless exists $skip_directories->{$key}; > } > $install .= qq( >-install :: all install_koha set_koha_ownership set_koha_permissions warn_koha_env_vars >+install :: install_koha set_koha_ownership set_koha_permissions warn_koha_env_vars > \t\$(NOECHO) \$(NOOP) > ); > $install .= "install_koha ::\n"; >-- >2.49.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39623
:
180896
|
180897
| 182072