Bugzilla – Attachment 182083 Details for
Bug 39857
OAI expanded_avs option broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39857: Regression tests
Bug-39857-Regression-tests.patch (text/plain), 4.01 KB, created by
Tomás Cohen Arazi (tcohen)
on 2025-05-08 13:30:33 UTC
(
hide
)
Description:
Bug 39857: Regression tests
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2025-05-08 13:30:33 UTC
Size:
4.01 KB
patch
obsolete
>From ffad51d2b381810195e9c960aab3118d67bf973c Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Thu, 8 May 2025 10:26:17 -0300 >Subject: [PATCH] Bug 39857: Regression tests > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > t/db_dependent/Koha/OAI/Server/Repository.t | 106 ++++++++++++++++++++ > 1 file changed, 106 insertions(+) > create mode 100755 t/db_dependent/Koha/OAI/Server/Repository.t > >diff --git a/t/db_dependent/Koha/OAI/Server/Repository.t b/t/db_dependent/Koha/OAI/Server/Repository.t >new file mode 100755 >index 00000000000..b767a58e296 >--- /dev/null >+++ b/t/db_dependent/Koha/OAI/Server/Repository.t >@@ -0,0 +1,106 @@ >+#!/usr/bin/perl >+ >+# This file is part of Koha >+# >+# Koha is free software; you can redistribute it and/or modify it >+# under the terms of the GNU General Public License as published by >+# the Free Software Foundation; either version 3 of the License, or >+# (at your option) any later version. >+# >+# Koha is distributed in the hope that it will be useful, but >+# WITHOUT ANY WARRANTY; without even the implied warranty of >+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >+# GNU General Public License for more details. >+# >+# You should have received a copy of the GNU General Public License >+# along with Koha; if not, see <http://www.gnu.org/licenses>. >+ >+use Modern::Perl; >+use Test::NoWarnings; >+use Test::More tests => 2; # N + 1 (NoWarnings) >+use Test::MockModule; >+use Test::Exception; >+ >+use DDP; >+use MARC::Record; >+use MARC::File::XML; >+ >+use Koha::Caches; >+use Koha::Database; >+use Koha::OAI::Server::Repository; >+ >+use t::lib::Mocks; >+use t::lib::TestBuilder; >+ >+my $schema = Koha::Database->new->schema; >+my $builder = t::lib::TestBuilder->new; >+ >+subtest 'get_biblio_marcxml() tests' => sub { >+ >+ plan tests => 2; >+ >+ $schema->storage->txn_begin; >+ >+ # disable config, we are gonna force it >+ t::lib::Mocks::mock_preference( 'marcflavour', 'MARC21' ); >+ t::lib::Mocks::mock_preference( 'OAI-PMH:ConfFile', 1 ); # so it loads the mocked one >+ t::lib::Mocks::mock_preference( 'OpacHiddenItems', '' ); >+ >+ my $library = >+ $builder->build_object( { class => 'Koha::Libraries', value => { branchname => q{Nick's Library} } } ); >+ my $item = $builder->build_sample_item( { library => $library->id } ); >+ >+ my $cache = Koha::Caches->get_instance; >+ $cache->clear_from_cache("MarcCodedFields-"); >+ >+ # Clear GetAuthorisedValueDesc-generated cache >+ $cache->clear_from_cache("libraries:name"); >+ $cache->clear_from_cache("itemtype:description:en"); >+ $cache->clear_from_cache("cn_sources:description"); >+ >+ my $cgi = Test::MockModule->new('CGI'); >+ $cgi->mock( 'Vars', sub { ( 'verb', 'Identify' ); } ); >+ my $yaml = Test::MockModule->new('YAML::XS'); >+ $yaml->mock( >+ 'LoadFile', >+ sub { >+ return { >+ format => { >+ not_expanded => { >+ include_items => 1, >+ expanded_avs => 0, >+ }, >+ expanded => { >+ include_items => 1, >+ expanded_avs => 1, >+ } >+ } >+ }; >+ } >+ ); >+ >+ # Initialize $repository object, silence output >+ my $repository; >+ { >+ my $stdout; >+ local *STDOUT; >+ open STDOUT, '>', \$stdout; >+ $repository = Koha::OAI::Server::Repository->new(); >+ } >+ >+ # not expanded case >+ my ($xml) = $repository->get_biblio_marcxml( $item->biblionumber, 'not_expanded' ); >+ my $record = MARC::Record->new_from_xml($xml); >+ my $item_field = $record->field('952'); >+ >+ is( $item_field->subfield('a'), $library->branchcode ); >+ >+ # expanded case >+ ($xml) = $repository->get_biblio_marcxml( $item->biblionumber, 'expanded' ); >+ $record = MARC::Record->new_from_xml($xml); >+ $item_field = $record->field('952'); >+ >+ is( $item_field->subfield('a'), $library->branchname ); >+ >+ $schema->storage->txn_rollback; >+}; >-- >2.49.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39857
:
182037
|
182045
| 182083 |
182084