Bugzilla – Attachment 182084 Details for
Bug 39857
OAI expanded_avs option broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39857: Fix expanded_avs option for OAI
Bug-39857-Fix-expandedavs-option-for-OAI.patch (text/plain), 1.91 KB, created by
Tomás Cohen Arazi (tcohen)
on 2025-05-08 13:30:35 UTC
(
hide
)
Description:
Bug 39857: Fix expanded_avs option for OAI
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2025-05-08 13:30:35 UTC
Size:
1.91 KB
patch
obsolete
>From 8344a87d83bcb3dddd489d53046414a203fbdd77 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 7 May 2025 17:59:25 +0000 >Subject: [PATCH] Bug 39857: Fix expanded_avs option for OAI > >This patch correct the call to filter the record > >To test: >1 - Enable OAI >2 - Set OAI-PMH:ConfFile to '/var/lib/koha/kohadev/OAI.yaml' >3 - Edit/create the file above to have content: >format: > marcxml: > metadataPrefix: marcxml > metadataNamespace: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim > schema: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd > include_items: 1 > expanded_avs: 1 >4 - save and restart_all >5 - View some records: > http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml >6 - Note the items show coded values >7 - Apply the regressions tests patch >8 - Run: > $ ktd --shell > k$ prove t/db_dependent/Koha/OAI/Server/Repository.t >=> FAIL: Tests fail! >9 - Apply this patch >10 - Restart all >11 - Refresh and confirm items now have descriptions >12 - Repeat 8 >=> SUCCESS: Tests pass! > >Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >Edit (tcohen): Amended the test plan to include the added regression >tests run >--- > Koha/OAI/Server/Repository.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/OAI/Server/Repository.pm b/Koha/OAI/Server/Repository.pm >index 0f745e10a6b..071012299bd 100644 >--- a/Koha/OAI/Server/Repository.pm >+++ b/Koha/OAI/Server/Repository.pm >@@ -197,7 +197,7 @@ sub get_biblio_marcxml { > $record = $biblio->metadata_record( > { > embed_items => $with_items, >- expand_coded_values => $expanded_avs, >+ expand_coded_fields => $expanded_avs, > interface => 'opac' > } > ); >-- >2.49.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39857
:
182037
|
182045
|
182083
| 182084