Bugzilla – Attachment 182151 Details for
Bug 38899
Allow the Vue toolbar to be sticky
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38899: (QA follow-up) Match buttons to patron toolbar
Bug-38899-QA-follow-up-Match-buttons-to-patron-too.patch (text/plain), 2.88 KB, created by
Matt Blenkinsop
on 2025-05-09 07:28:27 UTC
(
hide
)
Description:
Bug 38899: (QA follow-up) Match buttons to patron toolbar
Filename:
MIME Type:
Creator:
Matt Blenkinsop
Created:
2025-05-09 07:28:27 UTC
Size:
2.88 KB
patch
obsolete
>From 89d2333910bd2180e922ea749a8e62bebf53478e Mon Sep 17 00:00:00 2001 >From: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> >Date: Tue, 6 May 2025 11:34:38 +0100 >Subject: [PATCH] Bug 38899: (QA follow-up) Match buttons to patron toolbar > >--- > .../prog/js/vue/components/ButtonSubmit.vue | 9 ++++++++- > .../prog/js/vue/components/Vendors/VendorFormAdd.vue | 3 ++- > .../intranet-tmpl/prog/js/vue/modules/acquisitions.ts | 4 +++- > 3 files changed, 13 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ButtonSubmit.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ButtonSubmit.vue >index 58738e32d55..cd0e84d83ed 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ButtonSubmit.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ButtonSubmit.vue >@@ -1,5 +1,8 @@ > <template> >- <input type="submit" class="btn btn-primary" :value="text" /> >+ <button type="submit" class="btn btn-primary"> >+ <font-awesome-icon v-if="icon" :icon="icon" /> >+ {{ text }} >+ </button> > </template> > > <script> >@@ -11,6 +14,10 @@ export default { > default: __("Submit"), > required: false, > }, >+ icon: { >+ type: String, >+ required: false, >+ }, > }, > }; > </script> >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorFormAdd.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorFormAdd.vue >index 7674bda824d..47aa2ecd48a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorFormAdd.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorFormAdd.vue >@@ -7,11 +7,12 @@ > <h1 v-else>{{ $__("Add vendor") }}</h1> > <form @submit="onSubmit($event)" id="add_vendor"> > <Toolbar :sticky="true"> >- <ButtonSubmit :text="$__('Save')" /> >+ <ButtonSubmit :text="$__('Save')" icon="save" /> > <ToolbarButton > :to="{ name: 'VendorList' }" > :title="$__('Cancel')" > icon="times" >+ cssClass="btn btn-link" > > > </ToolbarButton> > </Toolbar> >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/modules/acquisitions.ts b/koha-tmpl/intranet-tmpl/prog/js/vue/modules/acquisitions.ts >index c24ca4c26b7..fa87ebbb460 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/modules/acquisitions.ts >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/modules/acquisitions.ts >@@ -13,6 +13,7 @@ import { > faSpinner, > faTrash, > faTimes, >+ faSave, > } from "@fortawesome/free-solid-svg-icons"; > import { FontAwesomeIcon } from "@fortawesome/vue-fontawesome"; > import vSelect from "vue-select"; >@@ -26,7 +27,8 @@ library.add( > faPlus, > faSpinner, > faTrash, >- faTimes >+ faTimes, >+ faSave > ); > > import App from "../components/Vendors/Main.vue"; >-- >2.48.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38899
:
176545
|
176546
|
181822
|
181823
|
181851
|
181852
|
181965
| 182151