Bugzilla – Attachment 182178 Details for
Bug 39696
Low contrast for claim return date in circulation overdue report
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39696: Set text-bg-info on badge
Bug-39696-Set-text-bg-info-on-badge.patch (text/plain), 2.49 KB, created by
Martin Renvoize (ashimema)
on 2025-05-09 14:15:25 UTC
(
hide
)
Description:
Bug 39696: Set text-bg-info on badge
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-05-09 14:15:25 UTC
Size:
2.49 KB
patch
obsolete
>From d8b5d6183f9478de3584275562c22dec5ee8130f Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Thu, 8 May 2025 14:29:26 +0100 >Subject: [PATCH] Bug 39696: Set text-bg-info on badge > >With bootstrap 5, a 'badge' class should always be accompanied by a >text-bg-# class. This second class sets the badge color and an >appropriate forground text color to ensure appropriate contrast. > >Steps to test: >1. Enable the ability to mark items as "Claimed Returned" by setting > the ClaimReturnedLostValue system preference. >2. Check out an item to a patron, and backdate the due date so that it > becomes overdue. >3. Navigate to: /cgi-bin/koha/circ/overdue.pl to view the overdue item. >4. Mark the item as "Claims Returned". >5. Observe the display: the claim return date text uses #fff (white), > which is not visible on white table rows and has poor contrast on > grey rows. >6. Apply the patch >7. Clear cache in browser and observe the display: the claim return date > badge is now blue with black text. >8. Sign off and have an amazing day! :D > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt >index cd9efbccaa1..796a55a8760 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt >@@ -148,7 +148,7 @@ > [% IF Koha.Preference('ClaimReturnedLostValue') %] > <td> > [% IF ( overdueloo.return_claim_created_on ) %] >- <span class="badge">[% overdueloo.return_claim_created_on | $KohaDates with_hours => 1 %]</span> >+ <span class="badge text-bg-info">[% overdueloo.return_claim_created_on | $KohaDates with_hours => 1 %]</span> > [% ELSE %] > <a class="btn btn-default btn-xs claim-returned-btn" data-itemnumber="[% overdueloo.itemnum | html %]"> <i class="fa fa-exclamation-circle"></i> Claim returned </a> > [% END %] >-- >2.49.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39696
:
181261
|
181569
|
182085
|
182086
|
182163
|
182164
| 182178 |
182179