Bugzilla – Attachment 182224 Details for
Bug 23010
If an item is checked out or in transit it should not be able to be marked withdrawn
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23010: (QA follow-up) a few trivial fixes
Bug-23010-QA-follow-up-a-few-trivial-fixes.patch (text/plain), 4.07 KB, created by
Emily Lamancusa (emlam)
on 2025-05-09 17:51:02 UTC
(
hide
)
Description:
Bug 23010: (QA follow-up) a few trivial fixes
Filename:
MIME Type:
Creator:
Emily Lamancusa (emlam)
Created:
2025-05-09 17:51:02 UTC
Size:
4.07 KB
patch
obsolete
>From be7ebf6e05996fcd96b75257ecd80cebf82e1da4 Mon Sep 17 00:00:00 2001 >From: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >Date: Fri, 9 May 2025 13:43:53 -0400 >Subject: [PATCH] Bug 23010: (QA follow-up) a few trivial fixes > >- Update the dbrev to use say_success, and make dbrev and installer > consistent >- Change error div in moredetail.tt from info to warning > >Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >--- > .../bug_23010_add_PreventWithdrawingItemsStatus.pl | 4 ++-- > installer/data/mysql/mandatory/sysprefs.sql | 2 +- > .../intranet-tmpl/prog/en/modules/catalogue/moredetail.tt | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_23010_add_PreventWithdrawingItemsStatus.pl b/installer/data/mysql/atomicupdate/bug_23010_add_PreventWithdrawingItemsStatus.pl >index 1fa805b3e7..f279bd5021 100755 >--- a/installer/data/mysql/atomicupdate/bug_23010_add_PreventWithdrawingItemsStatus.pl >+++ b/installer/data/mysql/atomicupdate/bug_23010_add_PreventWithdrawingItemsStatus.pl >@@ -11,10 +11,10 @@ return { > $dbh->do( > q{ > INSERT IGNORE INTO systempreferences (`variable`,`value`,`options`,`explanation`,`type`) >- VALUES ('PreventWithdrawingItemsStatus',NULL,'','Prevent the withdrawing of items based on statuses','Choice') >+ VALUES ('PreventWithdrawingItemsStatus','','','Prevent the withdrawing of items based on statuses','multiple') > } > ); > >- say $out "Added new system preference 'PreventWithdrawingItemsStatus'"; >+ say_success( $out, "Added new system preference 'PreventWithdrawingItemsStatus'" ); > }, > }; >diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql >index 26fa67dc59..4b15306e6e 100644 >--- a/installer/data/mysql/mandatory/sysprefs.sql >+++ b/installer/data/mysql/mandatory/sysprefs.sql >@@ -645,7 +645,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('PreservationNotForLoanDefaultTrainIn', '', '', 'Not for loan to apply to items removed from the preservation waiting list', 'TextArea'), > ('PreservationNotForLoanWaitingListIn', '', '', 'Not for loan to apply to items added to the preservation waiting list', 'TextArea'), > ('PreserveSerialNotes','1','','When a new "Expected" issue is generated, should it be prefilled with last created issue notes?','YesNo'), >-('PreventWithdrawingItemsStatus', '1', '', 'Prevent the withdrawing of items based on certain statuses' , 'multiple'), >+('PreventWithdrawingItemsStatus', '', '', 'Prevent the withdrawing of items based on certain statuses' , 'multiple'), > ('previousIssuesDefaultSortOrder','asc','asc|desc','Specify the sort order of Previous Issues on the circulation page','Choice'), > ('PrintNoticesMaxLines','0','','If greater than 0, sets the maximum number of lines an overdue notice will print. If the number of items is greater than this number, the notice will end with a warning asking the borrower to check their online account for a full list of overdue items.','Integer'), > ('PrivacyPolicyConsent','','Enforced|Permissive|Disabled','Data privacy policy consent in the OPAC', 'Choice'), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >index 2a3d57d1ff..84526221a9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >@@ -153,7 +153,7 @@ > [% SET not_for_loan_description = AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.notforloan', authorised_value => item.notforloan ) %] > [% END %] > [% IF withdraw_error %] >- <div class="alert alert-info"> >+ <div class="alert alert-warning"> > [% IF withdraw_error == 'intransit_cannot_withdraw' %] > Cannot withdraw item in transit. > [% END %] >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23010
:
176241
|
177299
|
177402
|
177413
|
177434
|
177435
|
177436
|
177437
|
177451
|
177452
|
177453
|
177454
|
177911
|
177912
|
177913
|
177914
|
178808
|
181322
|
181323
|
181324
|
181325
|
181326
|
181327
|
181400
|
182124
|
182129
|
182130
|
182131
|
182201
|
182212
|
182213
|
182214
|
182215
|
182216
|
182217
|
182218
|
182219
|
182220
|
182221
|
182222
|
182223
| 182224