Bugzilla – Attachment 182228 Details for
Bug 39679
Missing space before barcode in holds table with item-specific hold
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39679: (follow-up) Improve consistency
Bug-39679-follow-up-Improve-consistency.patch (text/plain), 1.87 KB, created by
David Nind
on 2025-05-09 20:50:02 UTC
(
hide
)
Description:
Bug 39679: (follow-up) Improve consistency
Filename:
MIME Type:
Creator:
David Nind
Created:
2025-05-09 20:50:02 UTC
Size:
1.87 KB
patch
obsolete
>From 43d15e26ee8963a4e6a4f8ac1ed18f52601a0ed3 Mon Sep 17 00:00:00 2001 >From: David Nind <david@davidnind.com> >Date: Fri, 9 May 2025 20:42:53 +0000 >Subject: [PATCH] Bug 39679: (follow-up) Improve consistency > >This improves the consistency with other areas of Koha: >1. A space before the barcode: "Only item 3999....". >2. Where there is no barcode: "Only item [No barcode]". > >Signed-off-by: David Nind <david@davidnind.com> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >index 6fa18c3517..6f6f0804de 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >@@ -229,12 +229,11 @@ > </a> > [%- ELSE -%] > <select name="change_hold_type_[% hold.reserve_id | html %]"> >- <option selected="selected" value="" >- >Only item >+ <option selected="selected" value=""> > [%- IF ( hold.barcodenumber ) -%] >- [%- ' ' _ hold.barcodenumber | html -%] >+ Only item [%- hold.barcodenumber | html -%] > [%- ELSE -%] >- No barcode >+ Only item [No barcode] > [%- END -%] > </option> > <option value="1">Next available</option> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39679
:
181160
|
181168
|
181204
|
182091
|
182092
|
182120
| 182228 |
182253