Attachment 18224 Details for Bug 10259 – [PASSED QA] Bug 6399 - tooltip for tags that says 'separate by comma'

[patch] [PASSED QA] Bug 6399 - tooltip for tags that says 'separate by comma'

PASSED-QA-Bug-6399---tooltip-for-tags-that-says-se.patch (text/plain), 3.78 KB, created by Katrin Fischer on 2013-05-18 08:19:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2013-05-18 08:19:04 UTC

Size: 3.78 KB

patch

obsolete

>From 445fbc01c49814df9cefc6fd921184350716df22 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 15 May 2013 08:45:32 -0400
>Subject: [PATCH] [PASSED QA] Bug 6399 - tooltip for tags that says 'separate
> by comma'
>
>Some sites split tags on spaces, some on commas. Since Koha splits on a
>comma, we should make that clear to the patron. This patch adds
>additional text to the "New tag(s)" label.
>
>To test, enable TagsEnabled, TagsInputOnDetail, and TagsInputOnList.
>Click "Add tag" on both OPAC search results and an OPAC detail page.
>Confirm that the revised label appears correctly.
>
>Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
>all tests pass
>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>All tests pass. There are some more places where we can
>add tags to multiple records at once, I noted them on the bug.
>
>http://bugs.koha-community.org/show_bug.cgi?id=10259
>---
> koha-tmpl/opac-tmpl/prog/en/css/opac.css           |    4 ++++
> koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt |    2 +-
> .../opac-tmpl/prog/en/modules/opac-results.tt      |    2 +-
> 3 files changed, 6 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/prog/en/css/opac.css b/koha-tmpl/opac-tmpl/prog/en/css/opac.css
>index c081075..24a62a1 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/css/opac.css
>+++ b/koha-tmpl/opac-tmpl/prog/en/css/opac.css
>@@ -1448,6 +1448,10 @@ padding-left : .4em;
>     margin-top : .5em;
> }
> 
>+.actions a {
>+    white-space: nowrap;
>+}
>+
> .m880 {
>     display:block; 
>     text-align:right; 
>diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
>index a8dabf3..1e9d635 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
>+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
>@@ -785,7 +785,7 @@ YAHOO.util.Event.onContentReady("furtherm", function () {
>         [% IF ( loggedinusername ) %]
>             <a class="tag_add" id="tag_add[% biblionumber %]" href="#">Add</a>
>             <form id="tagform[% biblionumber %]" method="post" action="/cgi-bin/koha/opac-tags.pl" style="display:none;">
>-                <label for="newtag[% biblionumber %]">New tag(s):</label>
>+                <label for="newtag[% biblionumber %]">New tag(s), separated by a comma:</label>
>                 <input name="newtag[% biblionumber %]" id="newtag[% biblionumber %]" maxlength="100" type="text"/>
>                 <input name="tagbutton" class="input tagbutton" title="[% biblionumber %]" type="submit" value="Add" />
>                 <a class="cancel_tag_add" id="cancel[% biblionumber %]" href="#">(done)</a>
>diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
>index 0704f06..0ad8f7b 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
>+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
>@@ -646,7 +646,7 @@ $(document).ready(function(){
>                     [% IF ( loggedinusername ) %]
>                         <a class="tag_add" id="tag_add[% SEARCH_RESULT.biblionumber %]" href="#">Add tag</a>
>                         <span id="tagform[% SEARCH_RESULT.biblionumber %]" class="tag_results_input" style="display:none;">
>-                          <label for="newtag[% SEARCH_RESULT.biblionumber %]">New tag(s):</label>
>+                          <label for="newtag[% SEARCH_RESULT.biblionumber %]">New tag(s), separated by a comma:</label>
>                           <input name="newtag[% SEARCH_RESULT.biblionumber %]" id="newtag[% SEARCH_RESULT.biblionumber %]" maxlength="100" />
>                           <input name="tagbutton" class="tagbutton" title="[% SEARCH_RESULT.biblionumber %]" type="submit" value="Add" />
>                           <a class="cancel_tag_add" id="cancel[% SEARCH_RESULT.biblionumber %]" href="#">(done)</a>
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 10259: 18170 | 18171 | 18176 | 18224