Bugzilla – Attachment 182253 Details for
Bug 39679
Missing space before barcode in holds table with item-specific hold
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39679: (QA follow-up) Translation friendly approach
Bug-39679-QA-follow-up-Translation-friendly-approa.patch (text/plain), 1.95 KB, created by
Martin Renvoize (ashimema)
on 2025-05-12 08:45:28 UTC
(
hide
)
Description:
Bug 39679: (QA follow-up) Translation friendly approach
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-05-12 08:45:28 UTC
Size:
1.95 KB
patch
obsolete
>From 3ee804ccaa9438e5e7eadf25db6937ffb6527d24 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Mon, 12 May 2025 09:39:13 +0100 >Subject: [PATCH] Bug 39679: (QA follow-up) Translation friendly approach > >As discussed at length on (mattermost)[https://chat.koha-community.org/koha-community/pl/wiopmtr7j3835df3yfi6q64ooy] we need to use the I18N library to properly handle this otherwise we will end up with TT tags inside the translatable strings. > >We can not use <span> here as we are inside an <option> tag and nesting ><span> insdie <option> is against the html standard. > >Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >index 6f6f0804deb..732677977f2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >@@ -231,9 +231,9 @@ > <select name="change_hold_type_[% hold.reserve_id | html %]"> > <option selected="selected" value=""> > [%- IF ( hold.barcodenumber ) -%] >- Only item [%- hold.barcodenumber | html -%] >+ [% tx("Only item {barcode}", {barcode = hold.barcodenumber}) | html %] > [%- ELSE -%] >- Only item [No barcode] >+ [% t("Only item [No barcode]") | html %] > [%- END -%] > </option> > <option value="1">Next available</option> >-- >2.49.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39679
:
181160
|
181168
|
181204
|
182091
|
182092
|
182120
|
182228
| 182253