Bugzilla – Attachment 182352 Details for
Bug 39888
Error on acquisitions home when no budgets are defined
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39888: Prevent load of superflous JS when table is not present
Bug-39888-Prevent-load-of-superflous-JS-when-table.patch (text/plain), 1.40 KB, created by
Martin Renvoize (ashimema)
on 2025-05-13 10:41:38 UTC
(
hide
)
Description:
Bug 39888: Prevent load of superflous JS when table is not present
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-05-13 10:41:38 UTC
Size:
1.40 KB
patch
obsolete
>From 40924b2a64032c02282edf4c6af51b1335507074 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Tue, 13 May 2025 11:36:12 +0100 >Subject: [PATCH] Bug 39888: Prevent load of superflous JS when table is not > present > >We shouldn't attempt to load the JS block for dealing with the budgets >table if there is no budgets defined and thus no budgets table. > >Test plan >1) Remove all budgets >2) Load acqui-home.pl and note an error in the browser console >3) Apply the patch >4) Reload acqui-home.pl and note the errors have gone > >Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt >index ecdefbb0a4c..bf445300c54 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt >@@ -206,6 +206,7 @@ > [% INCLUDE 'datatables.inc' %] > [% Asset.js("lib/jquery/plugins/treetable/jquery.treetable.js") | $raw %] > [% Asset.js("js/acquisitions-menu.js") | $raw %] >+ [% IF loop_budget %] > <script> > dt_overwrite_html_sorting_localeCompare(); > >@@ -282,5 +283,6 @@ > > }); > </script> >+ [% END %] > [% END %] > [% INCLUDE 'intranet-bottom.inc' %] >-- >2.49.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39888
:
182352
|
182353