Bugzilla – Attachment 182414 Details for
Bug 39492
Add missing aria label on the OPAC holdings table browse shelf link
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39492: Accessibility - add aria label to the OPAC browse shelf link
Bug-39492-Accessibility---add-aria-label-to-the-OP.patch (text/plain), 3.43 KB, created by
Martin Renvoize (ashimema)
on 2025-05-13 19:52:57 UTC
(
hide
)
Description:
Bug 39492: Accessibility - add aria label to the OPAC browse shelf link
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-05-13 19:52:57 UTC
Size:
3.43 KB
patch
obsolete
>From 36825478539a6dc479d3cb0c654692814b05affe Mon Sep 17 00:00:00 2001 >From: John Doe <you@example.com> >Date: Wed, 2 Apr 2025 14:31:05 +0000 >Subject: [PATCH] Bug 39492: Accessibility - add aria label to the OPAC browse > shelf link > >An accessibility audit highlighted that the browse shelf link on a >record's holding page does not provide enough context for visually >impaired users. The suggested solution was to add aria labels to provide >context. > >Test plan: >1. Ensure that you have at least one item with a call number. >2. Navigate to the records's page and scroll down to the holdings table. >3. Right click and choose inspect on the 'Browse shelf' link and note > that there is not an aria label. >4. Apply the patch. >5. Refresh the page and repeat step 3. >6. Note that there is now an aria label that adds context to the browse shelf > link - it now includes the title of the record, for example: > ...aria-label="Browse Shelf for Programming Perl /"... > >Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> >--- > .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index 59e4c959696..dd1ecfe81e0 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -1425,11 +1425,16 @@ > [% ITEM_RESULT.itemcallnumber | html %] > [% IF ( OPACShelfBrowser ) %] > [% IF ( ITEM_RESULT.itemnumber == starting_itemnumber ) %] >- (<a class="close_shelf" href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% ITEM_RESULT.biblionumber | html %]&shelfbrowse_itemnumber=[% ITEM_RESULT.itemnumber | html %]#[% tab | html %]" >- >Browse shelf<span class="sr-only">(Opens below)</span></a >+ (<a >+ class="close_shelf" >+ href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% ITEM_RESULT.biblionumber | html %]&shelfbrowse_itemnumber=[% ITEM_RESULT.itemnumber | html %]#[% tab | html %]" >+ aria-label="Browse Shelf for [% title %]" >+ >Browse shelf???<span class="sr-only">(Opens below)</span></a > >) > [% ELSE %] >- (<a href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% ITEM_RESULT.biblionumber | uri %]&shelfbrowse_itemnumber=[% ITEM_RESULT.itemnumber | uri %]#[% tab | uri %]" >+ (<a >+ href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% ITEM_RESULT.biblionumber | uri %]&shelfbrowse_itemnumber=[% ITEM_RESULT.itemnumber | uri %]#[% tab | uri %]" >+ aria-label="Browse Shelf for [% title %]" > >Browse shelf<span class="sr-only">(Opens below)</span></a > >) > [% END %] >-- >2.49.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39492
:
180412
|
180524
|
181501
|
181502
|
181572
|
181573
| 182414 |
182415
|
182416