Bugzilla – Attachment 182514 Details for
Bug 39915
Late issues export exports empty rows in CSV
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39915: Restore CSV export of late issues
Bug-39915-Restore-CSV-export-of-late-issues.patch (text/plain), 2.75 KB, created by
Paul Derscheid
on 2025-05-16 10:34:14 UTC
(
hide
)
Description:
Bug 39915: Restore CSV export of late issues
Filename:
MIME Type:
Creator:
Paul Derscheid
Created:
2025-05-16 10:34:14 UTC
Size:
2.75 KB
patch
obsolete
>From 9b0501d4c071b23df9b26eae4bc5918435b12f17 Mon Sep 17 00:00:00 2001 >From: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> >Date: Fri, 16 May 2025 11:01:17 +0100 >Subject: [PATCH] Bug 39915: Restore CSV export of late issues > >This patch restores the ability to export late serial claims to CSV > >Test plan: >1) Create a new subscription, setting the vendor id as 1 >2) Set the subscription start date as yesterday's date, the other > details aren't relevant so set whatever you want >3) Click into claims >4) If you get a warning saying no claims notice is defined then click > the link to define one (on the dropdown for the 'New notice' button > you want 'Claim serial issue. The content of the notice isn't > relevant here so input anything). Then head back to the claims page. > If no warning shows, proceed to the next step >5) Choose My Vendor and hit OK >6) You should see a table of claims with the first issue for your new > serial >7) Click the checkbox next to the row >8) Click the 'Download selected claims' button at the bottom >9) The CSV will download >10) Click into it - it will have the header but the rows will be blank >11) Apply patch >12) Hard refresh the page >13) Click the download button again >14) Check the new file, the rows will be filled out correctly with data > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt >index 0853ef14b7c..15a199cd75b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt >@@ -242,6 +242,7 @@ > $("#ExportSelected").click(function () { > // We need to use "input[name=serialid]:checked" instead of "input:checked". Otherwise, the "check all" box will pass the value of "on" as a serialid, which produces a SQL error. > var selected = $("input[name=serialid]:checked"); >+ var supplierid = [% supplierid | html %] > > if (selected.length == 0) { > alert(_("Please select at least one item to export.")); >@@ -249,7 +250,7 @@ > } > > // Building the url from currently checked boxes >- var url = "/cgi-bin/koha/serials/lateissues-export.pl?supplierid=&op=claims"; >+ var url = "/cgi-bin/koha/serials/lateissues-export.pl?supplierid=" + supplierid + "&op=claims"; > for (var i = 0; i < selected.length; i++) { > url += "&serialid=" + selected[i].value; > } >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39915
:
182511
|
182512
|
182513
| 182514