Bugzilla – Attachment 182549 Details for
Bug 39918
Unauthenticated request data should show when editing a request
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39918: Add unauthenticated details to edit request screen
Bug-39918-Add-unauthenticated-details-to-edit-requ.patch (text/plain), 4.86 KB, created by
David Nind
on 2025-05-16 18:22:20 UTC
(
hide
)
Description:
Bug 39918: Add unauthenticated details to edit request screen
Filename:
MIME Type:
Creator:
David Nind
Created:
2025-05-16 18:22:20 UTC
Size:
4.86 KB
patch
obsolete
>From 08a871b26945697a96559dd36518bc878bb6af12 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Fri, 16 May 2025 12:17:13 +0000 >Subject: [PATCH] Bug 39918: Add unauthenticated details to edit request screen > >Test plan, before applying patch: >1) Enable ILLModule and ILLOpacUnauthenticatedRequest >2) Log out, create a new unauthenticated request from the OPAC, visit: > <opac_url>/cgi-bin/koha/opac-illrequests.pl?backend=Standard&op=add_form >3) Login to Staff again, edit the request. (If ID is 1) visit: > <staff_url>/cgi-bin/koha/ill/ill-requests.pl?op=illview&illrequest_id=1 >4) Click 'Edit request'. Notice the unauthenticated data does not show. >5) Apply patch. Refresh the page. Notice the unauthenticated data now > shows. > >Signed-off-by: David Nind <david@davidnind.com> >--- > .../prog/en/modules/ill/ill-requests.tt | 50 +++++++++++-------- > 1 file changed, 29 insertions(+), 21 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >index 26ba077ed9..1585224b5d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >@@ -425,6 +425,10 @@ > <label for="notesopac" class="notesopac">OPAC notes:</label> > <textarea name="notesopac" id="notesopac" rows="5">[% request.notesopac | html %]</textarea> > </li> >+ [% IF stat == 'UNAUTH' %] >+ <h4>Unauthenticated request details</h4> >+ [% INCLUDE unauthenticated_details %] >+ [% END %] > </ol> > </fieldset> > <fieldset class="action"> >@@ -703,27 +707,7 @@ > <div class="rows"> > <h4>Unauthenticated request details</h4> > <ol> >- [% unauthenticated_first_name = request.extended_attributes.find({'type'=>'unauthenticated_first_name'}).value %] >- [% IF unauthenticated_first_name %] >- <li> >- <span class="label unauthenticated_first_name">First name:</span> >- [% unauthenticated_first_name | html %] >- </li> >- [% END %] >- [% unauthenticated_last_name = request.extended_attributes.find({'type'=>'unauthenticated_last_name'}).value %] >- [% IF unauthenticated_last_name %] >- <li> >- <span class="label unauthenticated_last_name">Last name:</span> >- [% unauthenticated_last_name | html %] >- </li> >- [% END %] >- [% unauthenticated_email = request.extended_attributes.find({'type'=>'unauthenticated_email'}).value %] >- [% IF unauthenticated_email %] >- <li> >- <span class="label unauthenticated_email">Email:</span> >- [% unauthenticated_email | html %] >- </li> >- [% END %] >+ [% INCLUDE unauthenticated_details %] > </ol> > </div> > [% END %] >@@ -1067,6 +1051,30 @@ > <!-- /#interlibraryloans --> > [% END %] > >+[% BLOCK unauthenticated_details %] >+ [% unauthenticated_first_name = request.extended_attributes.find({'type'=>'unauthenticated_first_name'}).value %] >+ [% IF unauthenticated_first_name %] >+ <li> >+ <span class="label unauthenticated_first_name">First name:</span> >+ [% unauthenticated_first_name | html %] >+ </li> >+ [% END %] >+ [% unauthenticated_last_name = request.extended_attributes.find({'type'=>'unauthenticated_last_name'}).value %] >+ [% IF unauthenticated_last_name %] >+ <li> >+ <span class="label unauthenticated_last_name">Last name:</span> >+ [% unauthenticated_last_name | html %] >+ </li> >+ [% END %] >+ [% unauthenticated_email = request.extended_attributes.find({'type'=>'unauthenticated_email'}).value %] >+ [% IF unauthenticated_email %] >+ <li> >+ <span class="label unauthenticated_email">Email:</span> >+ [% unauthenticated_email | html %] >+ </li> >+ [% END %] >+[% END %] >+ > [% MACRO jsinclude BLOCK %] > [% INCLUDE 'datatables.inc' %] > [% INCLUDE 'js-biblio-format.inc' %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39918
:
182525
| 182549