Bugzilla – Attachment 182643 Details for
Bug 23978
Notes field in saved reports should allow for (scrubbed) HTML
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23978: Expose HTML in Reports
Bug-23978-Expose-HTML-in-Reports.patch (text/plain), 4.38 KB, created by
David Cook
on 2025-05-20 03:01:08 UTC
(
hide
)
Description:
Bug 23978: Expose HTML in Reports
Filename:
MIME Type:
Creator:
David Cook
Created:
2025-05-20 03:01:08 UTC
Size:
4.38 KB
patch
obsolete
>From 6f21e6dc4f935a838c5d8af0b1faa6e8d45a6abd Mon Sep 17 00:00:00 2001 >From: Theodoros Theodoropoulos <theod@lib.auth.gr> >Date: Tue, 21 Sep 2021 10:27:15 +0200 >Subject: [PATCH] Bug 23978: Expose HTML in Reports > >This patch updates the notes field to a $raw filter to prevent html >escaping of the data within it. > >Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Signed-off-by: David Cook <dcook@prosentient.com.au> >--- > .../en/modules/reports/guided_reports_start.tt | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index 081cbb05bc..c5d7536b57 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -849,7 +849,7 @@ > <input type="hidden" name="reportname" value="[% reportname | html %]" /> > <input type="hidden" name="group" value="[% group | html %]" /> > <input type="hidden" name="subgroup" value="[% subgroup | html %]" /> >- <input type="hidden" name="notes" value="[% notes | html %]" /> >+ <input type="hidden" name="notes" value="[% notes | $raw %]" /> > <input type="hidden" name="cache_expiry" value="[% cache_expiry | html %]" /> > <input type="hidden" name="cache_expiry_units" value="[% cache_expiry_units | html %]" /> > <input type="hidden" name="public" value="[% public | html %]" /> >@@ -883,7 +883,7 @@ > <input type="hidden" name="id" value="[% id | html %]" /> > <h1>Enter parameters for report [% name | html %]:</h1> > [% IF ( notes ) %] >- <p>[% notes | html %]</p> >+ <p>[% notes | $raw %]</p> > [% END %] > <fieldset class="rows"> > <ol> >@@ -943,7 +943,7 @@ > > > <div class="page-section"> > [% IF ( notes ) %] >- <p><span class="label">Notes:</span> [% notes | html %]</p> >+ <p><span class="label">Notes:</span> [% notes | $raw %]</p> > [% END %] > [% IF ( unlimited_total ) %] > <p> >@@ -1415,7 +1415,7 @@ > [% END # /IF (usecache) %] > <li> > <label for="notes">Notes:</label> >- <textarea id="notes" name="notes" cols="50" rows="2">[% notes | html %]</textarea> >+ <textarea id="notes" name="notes" cols="50" rows="2">[% notes | $raw %]</textarea> > </li> > </ol> > </fieldset> >@@ -1445,7 +1445,7 @@ > [% IF saved_results %] > <h1>Saved report results</h1> > <h2>[% name | html %]</h2> >- <p>[% notes | html %]</p> >+ <p>[% notes | $raw %]</p> > <table> > [% FOREACH rows IN saved_results %] > <tr> >@@ -1465,7 +1465,7 @@ > [% IF ( notes ) %] > <li> > <span class="label">Notes:</span> >- [% notes | html %] >+ [% notes | $raw %] > </li> > [% ELSE %] > >@@ -1533,7 +1533,7 @@ > [% END %] > <li> > <label for="notes">Notes:</label> >- <textarea id="notes" name="notes" cols="50" rows="2">[% notes | html %]</textarea> >+ <textarea id="notes" name="notes" cols="50" rows="2">[% notes | $raw %]</textarea> > </li> > </ol> > </fieldset> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23978
:
95107
|
95108
|
161711
|
182627
|
182628
|
182642
| 182643 |
182644