Bugzilla – Attachment 182687 Details for
Bug 39947
Use bg-*-subtle in preference to bg-* Bootstrap classes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39947: Do not use bg-* Bootstrap classes
Bug-39947-Do-not-use-bg--Bootstrap-classes.patch (text/plain), 7.77 KB, created by
Owen Leonard
on 2025-05-21 11:46:27 UTC
(
hide
)
Description:
Bug 39947: Do not use bg-* Bootstrap classes
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2025-05-21 11:46:27 UTC
Size:
7.77 KB
patch
obsolete
>From 60dc8ce6fc40d133a4ce5e109481d0fb7f31aa97 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 21 May 2025 11:08:19 +0000 >Subject: [PATCH] Bug 39947: Do not use bg-* Bootstrap classes > >This patch removes a few instances of the "bg-*" class from our >templates, and adds some CSS to ensure that we can safely add the >".bg-*-subtle" class to a div with ".page-section." > >To test, apply the patch and rebuild the staff interface CSS. > >- Go to Administration -> Circulation and fine rules. The information > about rules specificity should have a pale blue background matching > the color found in an "info" style alert. >- Go to Tools -> Import patrons. The "Notes" section should match what > you saw in the previous step. > NOTE: I made a small change to whitespace in the markup of this > section to prevent the database column list from displaying without > line breaks--an issue introduced by the global tidy. >- Go to Authorities and perform a search which will return results. > - Click Actions -> Merge on one of the results. An "info" style alert > should be shown at the top of the page, "Merging with authority..." > - Without completing a merge, go to the Authorities home page. You > should see an identical alert. >- In KTD, bibliographic record 369 can be used to test errors related to > encoding problems: > - Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=369 > and confirm that you see a "warning" style alert (a pale yellow > background). > - Edit that record and confirm you see a similar error messages on > that page. > >Sponsored-by: Athens County Public Libraries >--- > koha-tmpl/intranet-tmpl/prog/css/src/_mixins.scss | 2 +- > .../intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 2 +- > .../prog/en/modules/authorities/authorities-home.tt | 2 +- > .../prog/en/modules/authorities/searchresultlist.tt | 2 +- > .../intranet-tmpl/prog/en/modules/catalogue/detail.tt | 2 +- > .../prog/en/modules/cataloguing/addbiblio.tt | 2 +- > .../prog/en/modules/tools/import_borrowers.tt | 8 ++++++-- > 7 files changed, 12 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/_mixins.scss b/koha-tmpl/intranet-tmpl/prog/css/src/_mixins.scss >index 3f617e411b9..7f3e063b8a5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/_mixins.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/_mixins.scss >@@ -10,7 +10,7 @@ $nav-menu-bullet: url( "data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/ > margin-bottom: 1rem; > padding: 1rem; > >- &:not( .bg-danger, .bg-warning, .bg-info, .bg-success, .bg-primary, .action ) { >+ &:not( .bg-danger, .bg-warning, .bg-info, .bg-success, .bg-primary, .bg-danger-subtle, .bg-warning-subtle, .bg-info-subtle, .bg-success-subtle, .bg-primary-subtle, .action ) { > background-color: #FFF; > } > } >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >index 88a23d2b559..dbb7e1f9bd0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >@@ -50,7 +50,7 @@ > [% END %] > </h1> > >- <div class="page-section bg-info"> >+ <div class="page-section bg-info-subtle"> > <p>The rules are applied from most specific to less specific, using the first found in this order:</p> > <ul> > <li>same library, same patron category, same item type</li> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities-home.tt >index 3c75b05c227..1809a110cef 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities-home.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities-home.tt >@@ -32,7 +32,7 @@ > > <h1>Authorities</h1> > >- <div id="merge_in_progress" class="page-section bg-info" style="display:none;"></div> >+ <div id="merge_in_progress" class="alert alert-info" style="display:none;"></div> > > [%- SET StaffAuthoritiesHome = AdditionalContents.get( location => "StaffAuthoritiesHome", lang => lang, library => Branches.GetLoggedInBranchcode ) -%] > [%- FOREACH block IN StaffAuthoritiesHome.content -%] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt >index 67912d78187..861eca86c30 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt >@@ -45,7 +45,7 @@ > [% INCLUDE 'authorities-toolbar.inc' %] > <h1>Authority search results</h1> > >- <div id="merge_in_progress" class="page-section bg-info" style="display:none;"></div> >+ <div id="merge_in_progress" class="alert alert-info" style="display:none;"></div> > <div class="page-section"> > [% IF ( query_error ) %] > <div class="alert alert-warning" >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index dd588e48741..9135e7ef7d6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -103,7 +103,7 @@ > <div class="row"> > <div id="catalogue_detail_biblio" class="col"> > [% IF decoding_error || analytics_error %] >- <div class="page-section bg-danger"> >+ <div class="alert alert-warning"> > <h1>Errors found</h1> > [% IF decoding_error %] > <h2>Encoding errors</h2> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >index e74dcbb262f..003358530c5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >@@ -798,7 +798,7 @@ > > [% WRAPPER 'main-container.inc' wide_centered => 1 %] > [% IF ( INVALID_METADATA ) %] >- <div class="page-section bg-danger"> >+ <div class="alert alert-warning"> > <h1>Errors found</h1> > <p><strong>This record had encoding issues, non-xml characters have been stripped in order to allow editing. Please be cautious when saving that some data may have been removed from the record.</strong></p> > <pre class="problem">[% INVALID_METADATA | html %]</pre> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt >index c39b4115cb7..fefcd7a17e8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt >@@ -375,7 +375,7 @@ > [% END %] > > <div class="col-sm-6"> >- <div class="page-section bg-info"> >+ <div class="page-section bg-info-subtle"> > <h2>Notes:</h2> > <ul> > <li>The first line in the file must be a header row defining which columns you are supplying in the import file.</li> >@@ -390,7 +390,11 @@ > <li> > OR choose which fields you want to supply from the following list: > <ul> >- <li> [% FOREACH columnkey IN borrower_fields.keys.sort %]'[% columnkey | html %]',[% END %] </li> >+ <li> >+ [% FOREACH columnkey IN borrower_fields.keys.sort %] >+ '[% columnkey | html %]', >+ [% END %] >+ </li> > </ul> > </li> > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39947
:
182687
|
182725
|
182734
|
182743