Bugzilla – Attachment 182709 Details for
Bug 39957
Fix JS error on credit and debit types administration pages
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39957: Fix JS error on credit and debit types administration pages
Bug-39957-Fix-JS-error-on-credit-and-debit-types-a.patch (text/plain), 4.92 KB, created by
David Nind
on 2025-05-21 21:09:11 UTC
(
hide
)
Description:
Bug 39957: Fix JS error on credit and debit types administration pages
Filename:
MIME Type:
Creator:
David Nind
Created:
2025-05-21 21:09:11 UTC
Size:
4.92 KB
patch
obsolete
>From a48dbd2103464abfb1661214efe3f335ec2f9b7e Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 21 May 2025 15:34:10 +0000 >Subject: [PATCH] Bug 39957: Fix JS error on credit and debit types > administration pages > >This patch fixes an JS error in several administration pages, introduced >by Bug 39099 and 39810. We can't access a DOM node without checking for >its existence first. > >To test, apply the patch and go to Administration. > >- Check the following pages: > - Authorized values > - Credit types > - Debit types > - Item types > - Patron categories. >- On each page check the JavaScript console on the initial page. There > should be no errors. >- Check the add/edit page for each and confirm that the library > limitation Select2 widget works correctly. > >Sponsored-by: Athens County Public Libraries >Signed-off-by: David Nind <david@davidnind.com> >--- > .../prog/en/modules/admin/authorised_values.tt | 7 +++++-- > .../intranet-tmpl/prog/en/modules/admin/credit_types.tt | 6 ++++-- > .../intranet-tmpl/prog/en/modules/admin/debit_types.tt | 6 ++++-- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt | 7 +++++-- > koha-tmpl/intranet-tmpl/prog/js/categories.js | 6 ++++-- > 5 files changed, 22 insertions(+), 10 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt >index 999cfecd78..05384025ba 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt >@@ -439,8 +439,11 @@ > } > return true; > }); >- $("#library_limitation")[0].style.minWidth = "450px"; >- $("#library_limitation").select2(); >+ >+ if ($("#library_limitation").length > 0) { >+ $("#library_limitation")[0].style.minWidth = "450px"; >+ $("#library_limitation").select2(); >+ } > }); > </script> > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/credit_types.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/credit_types.tt >index 9ed0accb65..7fb1068645 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/credit_types.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/credit_types.tt >@@ -289,8 +289,10 @@ > //Start filtered > $("#filter_system").click(); > >- $("#library_limitation")[0].style.minWidth = "450px"; >- $("#library_limitation").select2(); >+ if ($("#library_limitation").length > 0) { >+ $("#library_limitation")[0].style.minWidth = "450px"; >+ $("#library_limitation").select2(); >+ } > }); > </script> > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/debit_types.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/debit_types.tt >index 65b7d96100..018bd5c665 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/debit_types.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/debit_types.tt >@@ -306,8 +306,10 @@ > //Start filtered > $("#filter_system").click(); > >- $("#library_limitation")[0].style.minWidth = "450px"; >- $("#library_limitation").select2(); >+ if ($("#library_limitation").length > 0) { >+ $("#library_limitation")[0].style.minWidth = "450px"; >+ $("#library_limitation").select2(); >+ } > }); > </script> > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt >index 98cf9de4c4..0f7915e365 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt >@@ -567,8 +567,11 @@ > if( $("#icons .tab-pane.active").length < 1 ){ > $("#icons a:first").tab("show"); > } >- $("#library_limitation")[0].style.minWidth = '450px'; >- $("#library_limitation").select2(); >+ >+ if ($("#library_limitation").length > 0) { >+ $("#library_limitation")[0].style.minWidth = "450px"; >+ $("#library_limitation").select2(); >+ } > }); > </script> > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/js/categories.js b/koha-tmpl/intranet-tmpl/prog/js/categories.js >index e9d3019347..72835e1f18 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/categories.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/categories.js >@@ -52,8 +52,10 @@ $(document).ready(function () { > table_settings > ); > >- $("#library_limitation")[0].style.minWidth = "450px"; >- $("#library_limitation").select2(); >+ if ($("#library_limitation").length > 0) { >+ $("#library_limitation")[0].style.minWidth = "450px"; >+ $("#library_limitation").select2(); >+ } > > $("#categorycode").on("blur", function () { > toUC(this); >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39957
:
182696
| 182709