Bugzilla – Attachment 182767 Details for
Bug 38412
Koha should warn when hold on bibliographic record requires hold policy override
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38412: Display warning on biblio level
Bug-38412-Display-warning-on-biblio-level.patch (text/plain), 2.00 KB, created by
Andrew Fuerste-Henry
on 2025-05-23 12:41:11 UTC
(
hide
)
Description:
Bug 38412: Display warning on biblio level
Filename:
MIME Type:
Creator:
Andrew Fuerste-Henry
Created:
2025-05-23 12:41:11 UTC
Size:
2.00 KB
patch
obsolete
>From 7812a8565852ce3998a772c156a5ec2d1d77e222 Mon Sep 17 00:00:00 2001 >From: Thibaud Guillot <thibaud.guillot@biblibre.com> >Date: Wed, 14 May 2025 13:52:37 +0000 >Subject: [PATCH] Bug 38412: Display warning on biblio level >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >When no element is available, with AllowHoldPolicyOverride, a triangle appears on each element to be forced, but if you choose ânext item availableâ without having any item available, you won't see anything. >I think there's a small correction to be made in request.pl because there's no incrementation of $num_override when the item is to be forced... > >So I added it and logic did the rest. > >Test plan: >1) Set circulations rules for specific category and/or itemtype (for example 0 hold allowed for staff on books). Set AllowHoldPolicyOverride on "Allow". >2) For testing go on biblio with books itemtype, and place a hold for a staff category patron >3) Normally you will see triangles on each item on specific section but you can force it. When you just select the next item available none triangle and none alert showing. >4) Apply this patch and restart_all >5) Refresh your browser page >6) Normally now there is a triangle into 'Place hold' submit button and an alert pops up after click on it. > >Sponsored by: BibLibre > >Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> >--- > reserve/request.pl | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/reserve/request.pl b/reserve/request.pl >index 5908ab692b7..a3653fcdd89 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -546,6 +546,7 @@ if ( ( $findborrower && $borrowernumber_hold || $findclub && $club_hold ) > if ( @pickup_locations || C4::Context->preference('AllowHoldPolicyOverride') ) { > $num_items_available++; > $item->{override} = 1; >+ $num_override++; > > my $default_pickup_location; > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38412
:
182450
| 182767