Bugzilla – Attachment 182829 Details for
Bug 40021
Koha/Plugins/Recall_hooks.t produces warnings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40021: Remove warnings from Koha/Plugins/Recall_hooks.t
Bug-40021-Remove-warnings-from-KohaPluginsRecallho.patch (text/plain), 1.61 KB, created by
Roman Dolny
on 2025-05-28 16:51:13 UTC
(
hide
)
Description:
Bug 40021: Remove warnings from Koha/Plugins/Recall_hooks.t
Filename:
MIME Type:
Creator:
Roman Dolny
Created:
2025-05-28 16:51:13 UTC
Size:
1.61 KB
patch
obsolete
>From 38edacaaa32775a668822e4426e78bdc86a368f7 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 28 May 2025 16:57:55 +0200 >Subject: [PATCH] Bug 40021: Remove warnings from Koha/Plugins/Recall_hooks.t > >Test plan: > prove t/db_dependent/Koha/Plugins/Recall_hooks.t >should return green > >Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> >--- > t/db_dependent/Koha/Plugins/Recall_hooks.t | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/Koha/Plugins/Recall_hooks.t b/t/db_dependent/Koha/Plugins/Recall_hooks.t >index f62911123d..2130ca5d06 100755 >--- a/t/db_dependent/Koha/Plugins/Recall_hooks.t >+++ b/t/db_dependent/Koha/Plugins/Recall_hooks.t >@@ -16,8 +16,9 @@ > > use Modern::Perl; > use File::Basename; >-use Test::More tests => 4; >+use Test::More tests => 5; > use Test::MockModule; >+use Test::NoWarnings; > use Test::Warn; > > use t::lib::Mocks; >@@ -86,7 +87,7 @@ subtest 'after_recall_action hook' => sub { > > C4::Circulation::AddIssue( $patron2, $item->barcode ); > >- warnings_exist { >+ warnings_like { > Koha::Recalls->add_recall( > { > patron => $patron1, >@@ -98,7 +99,10 @@ subtest 'after_recall_action hook' => sub { > } > ); > } >- qr/after_recall_action called with action: add, ref: Koha::Recall/, >+ [ >+ qr/transform_prepared_letter called with letter content/, >+ qr/after_recall_action called with action: add, ref: Koha::Recall/ >+ ], > '->add_recall calls the after_recall_action hook with action add'; > > Koha::Plugins->RemovePlugins; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40021
:
182826
| 182829